From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933885AbcHaLsf (ORCPT <rfc822;w@1wt.eu>);
        Wed, 31 Aug 2016 07:48:35 -0400
Received: from mout.kundenserver.de ([212.227.17.10]:62785 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932988AbcHaLsd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 31 Aug 2016 07:48:33 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Dongdong Liu <liudongdong3@huawei.com>
Cc: helgaas@kernel.org, rafael@kernel.org, Lorenzo.Pieralisi@arm.com,
        tn@semihalf.com, wangzhou1@hisilicon.com, pratyush.anand@gmail.com,
        linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, jcm@redhat.com,
        gabriele.paoloni@huawei.com, charles.chenxin@huawei.com,
        hanjun.guo@linaro.org, linuxarm@huawei.com
Subject: Re: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers
Date: Wed, 31 Aug 2016 13:48:16 +0200
Message-ID: <5406169.iVLlEcSJ8X@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1472644094-82731-4-git-send-email-liudongdong3@huawei.com>
References: <1472644094-82731-1-git-send-email-liudongdong3@huawei.com> <1472644094-82731-4-git-send-email-liudongdong3@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:AnZv1vdnN6eBbooxQbSu1kSjcukqjKeVYuwjXOqgzn9lxNh8qH9
 vfFSSXtOnLnomUPkVavVTxq1c1Eb9e+CpJdAnC8rwYHdMsqFAwpAQsW/e3C//LK7zpvS4e/
 LZ5z/pgG5ePnMn2Yh6jeAltTdyuj1hrP6fsiIckJOZ6sHAyaTJCC7uHvv4IzyOFHH8O9Zad
 bDWgLIsZ6cuW0CZgptQVw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:prYPkPKny+g=:ranhox+eed4tjNkG2sk+IP
 xXMAdCxiWoNN/smDdZRKseXK4UktP/TUhFCicdWe2Gmk8hTk9+uT7ydV45RFE88lTsh/gtV4E
 wW0jfa23bpZ3kJ8/bobqe3rfonsPsS+9vQHUaED5842UOarraQWSHhM1ARdSrBKRCr6ZVrSe0
 CbUiRKXMe/JsxwRDd1Yz2A7eAfNkHauJ1py8yqaFMp6ULMEJWhkLBl4gufehv/l9WMZVRNpgJ
 whajXtduIf7QsKwUrG7DyNgoG26hrfRqZA5XGhH1XqKFLvUQjVfWIqu0T/RY2MMaLVE8nEewA
 8Thic/yUeCh+MaIuOecA0lsewQz3+HL0HdVi31QLQnP8dEmE7JhLAL69jpCt4zCkf0loCuP3t
 JmIX3/enrKM72/9TPh5C5qGHlZEiRsn0E+kgLjDgMQ6w4MELvAX7BG73DhdgBgxITHNjdsIxj
 ROxLuBFa+9IfApnm2CVJ9RdQD6XwOmhEplY3h1j2FEs+U421v+B1yBJaFHw0VNhwFmOUXbbcC
 QmPF6Y/N6x45pWvmjuykacqOPyGd6gIL84TG0sBQYGArwzHRRs5gyGxuBUeMn2ctVn+piA9Ax
 ibhMwT0QGLOgaEa5Nt4MPJvqjg30gigUmErU3RHGkzdnE2LNwcQtOUwOErTCf0uk15MQyiH5F
 gplG7s+MMKnUlndZgtNJIPnG6+B7RO3hsSn8+V/OewFUwSYy0YMcFdUk+aaE8TPfTf7flKraZ
 B39cJ196VBqVqnhb
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, August 31, 2016 7:48:14 PM CEST Dongdong Liu wrote:
> +static struct hisi_rc_res rc_res[] = {
> +       {
> +               HIP05,
> +               {
> +                       DEFINE_RES_MEM(0xb0070000, SZ_4K),
> +                       DEFINE_RES_MEM(0xb0080000, SZ_4K),
> +                       DEFINE_RES_MEM(0xb0090000, SZ_4K),
> +                       DEFINE_RES_MEM(0xb00a0000, SZ_4K)
> +               }
> +       },
> +       {
> +               HIP06,
> +               {
> +                       DEFINE_RES_MEM(0xa0090000, SZ_4K),
> +                       DEFINE_RES_MEM(0xa0200000, SZ_4K),
> +                       DEFINE_RES_MEM(0xa00a0000, SZ_4K),
> +                       DEFINE_RES_MEM(0xa00b0000, SZ_4K)
> +               }
> +       },
> +       {
> +               HIP07,
> +               {
> +                       DEFINE_RES_MEM(0xa0090000, SZ_4K),
> +                       DEFINE_RES_MEM(0xa0200000, SZ_4K),
> +                       DEFINE_RES_MEM(0xa00a0000, SZ_4K),
> +                       DEFINE_RES_MEM(0xa00b0000, SZ_4K),
> +                       DEFINE_RES_MEM(0x8a0090000UL, SZ_4K),
> +                       DEFINE_RES_MEM(0x8a0200000UL, SZ_4K),
> +                       DEFINE_RES_MEM(0x8a00a0000UL, SZ_4K),
> +                       DEFINE_RES_MEM(0x8a00b0000UL, SZ_4K),
> +                       DEFINE_RES_MEM(0x600a0090000UL, SZ_4K),
> +                       DEFINE_RES_MEM(0x600a0200000UL, SZ_4K),
> +                       DEFINE_RES_MEM(0x600a00a0000UL, SZ_4K),
> +                       DEFINE_RES_MEM(0x600a00b0000UL, SZ_4K),
> +                       DEFINE_RES_MEM(0x700a0090000UL, SZ_4K),
> +                       DEFINE_RES_MEM(0x700a0200000UL, SZ_4K),
> +                       DEFINE_RES_MEM(0x700a00a0000UL, SZ_4K),
> +                       DEFINE_RES_MEM(0x700a00b0000UL, SZ_4K)
> +               }
> +       },

I don't know much about ACPI, but I'm pretty sure this is not
the normal way to find MMIO resources. Why not read them from
the ACPI tables?

	Arnd