From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Felipe Balbi <balbi@ti.com>,
kuninori morimoto <kuninori.morimoto.gx@renesas.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget: USB_RENESAS_USBHS_UDC should depend on HAS_DMA
Date: Wed, 3 Sep 2014 15:02:03 +0900 [thread overview]
Message-ID: <5406AEDB.2040702@renesas.com> (raw)
In-Reply-To: <1409340700-2033-1-git-send-email-geert@linux-m68k.org>
Hi Geert,
(2014/08/30 4:31), Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> drivers/built-in.o: In function `usbhsg_dma_map_ctrl':
> mod_gadget.c:(.text+0x53b226): undefined reference to `usb_gadget_map_request'
> mod_gadget.c:(.text+0x53b242): undefined reference to `usb_gadget_unmap_request'
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/usb/gadget/udc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
> index 5151f947a4f5..00171d436cf8 100644
> --- a/drivers/usb/gadget/udc/Kconfig
> +++ b/drivers/usb/gadget/udc/Kconfig
> @@ -163,7 +163,7 @@ config USB_R8A66597
>
> config USB_RENESAS_USBHS_UDC
> tristate 'Renesas USBHS controller'
> - depends on USB_RENESAS_USBHS
> + depends on USB_RENESAS_USBHS && HAS_DMA
> help
> Renesas USBHS is a discrete USB host and peripheral controller chip
> that supports both full and high speed USB 2.0 data transfers.
>
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
prev parent reply other threads:[~2014-09-03 6:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 19:31 [PATCH] usb: gadget: USB_RENESAS_USBHS_UDC should depend on HAS_DMA Geert Uytterhoeven
2014-09-03 6:02 ` Yoshihiro Shimoda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5406AEDB.2040702@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=balbi@ti.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox