Re: [PATCH] regulator: core: GPIO #0 is a valid GPIO

Mark Brown
2014-08-29T19:01:42Z

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

On Fri, Aug 29, 2014 at 10:19:16PM +0400, Dmitry Eremin-Solenikov wrote:
> From: Dirk Behme <dirk.behme@de.bosch.com>
>
> With GPIO #0, this if statement will always fail. Remove this, the
> check for gpio_is_valid() is sufficent here.

No, read the archives - this will break boards using zero as default.
Any current boards should be using DT and so shouldn't be using fixed
GPIO numbers in the first place which will mean they'll not end up
getting zero as a valid GPIO. If you are using zero as a GPIO for some
reason provide a way to specify that the GPIO is a real GPIO and not
just the default value for the struct.

> Change-Id: Ia10e8e9c74e11deba852fcd44040cc275b583cfd
> Signed-off-by: Gokulkrishnan Nagarajan <Gokulkrishnan.Nagarajan@in.bosch.com>
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>

In any case I can't apply this since you didn't sign it off and please
don't include noise from your internal review system in upstream
postings.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]