From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: linux-gpio@vger.kernel.org, Fan Wu <fwu@marvell.com>
Subject: Re: [PATCH] pinctrl: clean up after enable refactoring
Date: Wed, 03 Sep 2014 09:02:46 -0600 [thread overview]
Message-ID: <54072D96.6070906@wwwdotorg.org> (raw)
In-Reply-To: <1409742329-17411-1-git-send-email-linus.walleij@linaro.org>
On 09/03/2014 05:05 AM, Linus Walleij wrote:
> commit 2243a87d90b42eb38bc281957df3e57c712b5e56
> "pinctrl: avoid duplicated calling enable_pinmux_setting for a pin"
> removed the .disable callback from the struct pinmux_ops,
> making the .enable() callback the only remaining callback.
>
> However .enable() is a bad name as it seems to imply that a
> muxing can also be disabled. Rename the callback to .set_mux()
> and also take this opportunity to clean out any remaining
> mentions of .disable() from the documentation.
Acked-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2014-09-03 15:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 11:05 [PATCH] pinctrl: clean up after enable refactoring Linus Walleij
2014-09-03 11:26 ` Fan Wu
2014-09-03 11:59 ` Linus Walleij
2014-09-03 13:39 ` Fan Wu
2014-09-03 15:02 ` Stephen Warren [this message]
2014-09-03 16:14 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54072D96.6070906@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=fwu@marvell.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox