From: Nishanth Menon <nm@ti.com>
To: Tony Lindgren <tony@atomide.com>,
"Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Lee Jones <lee.jones@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Marek Belisko <marek@goldelico.com>, <linux-omap@vger.kernel.org>
Subject: Re: PROBLEM: bindings for drivers/mfd/twl4030-power.c
Date: Wed, 3 Sep 2014 13:50:57 -0500 [thread overview]
Message-ID: <54076311.2030306@ti.com> (raw)
In-Reply-To: <20140903184527.GG11766@atomide.com>
On 09/03/2014 01:45 PM, Tony Lindgren wrote:
> * Dr. H. Nikolaus Schaller <hns@goldelico.com> [140901 09:54]:
>> Hi,
>>
>> Am 25.08.2014 um 23:26 schrieb Tony Lindgren:
>>
>>> * Dr. H. Nikolaus Schaller <hns@goldelico.com> [140817 08:46]:
>>>> I am trying to make ti,use_poweroff work on 3.17-rc1 for the GTA04 board.
>>>> Poweroff was broken for a while and I found that the driver isn't loaded at all.
>>>>
>>>> It appears to me that commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
>>>> did rename the compatible entry from "ti,twl4030-power" to "ti,twl4030-power-reset"
>>>> but this was not documented in the bindings and of course our DT does not
>>>> match.
>>>>
>>>> Even your commit message talks about "ti,twl4030-power" although I can't find it
>>>> in the code.
>>>
>>> Hmm sorry did I accidentally remove ti,twl4030-power? If so, that should
>>> be added back for sure. Do you have a patch for that already?
>>
>> No, I have only updated our device tree because I don't know if it really should
>> be added back or not.
>>
>> As you say the "ti,twl4030-power" does not configure anything. So what
>> is it good for?
>
> Only for the poweroff if "ti,use_poweroff" is set. Care to do a patch
> as you clearly have a use case to test it with?
Tony, we were talking about supporting ti,system-power-controller as
the standard way of stating poweroff control is by the PMIC. this
seems to be standard in various SoCs. use_poweroff seems to predate
that standardization. Should'nt we start using
ti,system-power-controller instead?
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-09-03 18:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-17 15:43 PROBLEM: bindings for drivers/mfd/twl4030-power.c Dr. H. Nikolaus Schaller
2014-08-25 21:26 ` Tony Lindgren
2014-09-01 16:54 ` Dr. H. Nikolaus Schaller
2014-09-03 18:45 ` Tony Lindgren
2014-09-03 18:50 ` Nishanth Menon [this message]
2014-09-03 19:02 ` Tony Lindgren
2014-09-03 19:13 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54076311.2030306@ti.com \
--to=nm@ti.com \
--cc=hns@goldelico.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=marek@goldelico.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox