From: Shuah Khan <shuahkh@osg.samsung.com>
To: Pranith Kumar <bobby.prani@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
David Herrmann <dh.herrmann@gmail.com>,
"open list:KERNEL SELFTEST F..." <linux-api@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH Resend] memfd_test: Add missing argument to printf()
Date: Thu, 04 Sep 2014 12:31:57 -0600 [thread overview]
Message-ID: <5408B01D.50804@osg.samsung.com> (raw)
In-Reply-To: <1409846302-3513-1-git-send-email-bobby.prani@gmail.com>
On 09/04/2014 09:58 AM, Pranith Kumar wrote:
> Add a missing path argument buf to printf()
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
> ---
> tools/testing/selftests/memfd/memfd_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
> index 3634c90..c343df8 100644
> --- a/tools/testing/selftests/memfd/memfd_test.c
> +++ b/tools/testing/selftests/memfd/memfd_test.c
> @@ -205,7 +205,7 @@ static void mfd_fail_open(int fd, int flags, mode_t mode)
> sprintf(buf, "/proc/self/fd/%d", fd);
> r = open(buf, flags, mode);
> if (r >= 0) {
> - printf("open(%s) didn't fail as expected\n");
> + printf("open(%s) didn't fail as expected\n", buf);
> abort();
> }
> }
>
Thanks. I queued it for 3.17 fixes.
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
prev parent reply other threads:[~2014-09-04 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 15:58 [PATCH Resend] memfd_test: Add missing argument to printf() Pranith Kumar
2014-09-04 18:31 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5408B01D.50804@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=dh.herrmann@gmail.com \
--cc=hughd@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox