Re: [PATCH] cpufreq_opp: Fixed the order of argument for kcalloc.

Re: [PATCH] cpufreq_opp: Fixed the order of argument for kcalloc.

[Viresh Kumar]

On 16 August 2014 14:52, Anand Moon <moon.linux@yahoo.com> wrote:
> These changes fix the argument to the kcalloc
>         @n: number of elements.
>         @size: element size.
>         @flags: the type of memory to allocate (see kmalloc).
>
>         void *kcalloc(size_t n, size_t size, gfp_t flags)
>
> Signed-off-by: Anand Moon <moon.linux@yahoo.com>
> ---
>  drivers/cpufreq/cpufreq_opp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq_opp.c b/drivers/cpufreq/cpufreq_opp.c
> index f7a32d2..773bcde 100644
> --- a/drivers/cpufreq/cpufreq_opp.c
> +++ b/drivers/cpufreq/cpufreq_opp.c
> @@ -60,7 +60,7 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
>                 goto out;
>         }
>
> -       freq_table = kcalloc(sizeof(*freq_table), (max_opps + 1), GFP_ATOMIC);
> +       freq_table = kcalloc((max_opps + 1), sizeof(*freq_table), GFP_ATOMIC);
>         if (!freq_table) {
>                 ret = -ENOMEM;
>                 goto out;

Fixes: 3c5445c cpufreq: OPP: Avoid sleeping while atomic

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Re: [PATCH] cpufreq_opp: Fixed the order of argument for kcalloc.

[Stephen Boyd]

On 08/16/14 02:22, Anand Moon wrote:
> These changes fix the argument to the kcalloc
>         @n: number of elements.
>         @size: element size.
>         @flags: the type of memory to allocate (see kmalloc).
>
>         void *kcalloc(size_t n, size_t size, gfp_t flags)
>
> Signed-off-by: Anand Moon <moon.linux@yahoo.com>
> ---

Oops.

Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

Can this be picked up?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

Re: [PATCH] cpufreq_opp: Fixed the order of argument for kcalloc.

[Rafael J. Wysocki]

On Thursday, September 04, 2014 02:07:49 PM Stephen Boyd wrote:
> On 08/16/14 02:22, Anand Moon wrote:
> > These changes fix the argument to the kcalloc
> >         @n: number of elements.
> >         @size: element size.
> >         @flags: the type of memory to allocate (see kmalloc).
> >
> >         void *kcalloc(size_t n, size_t size, gfp_t flags)
> >
> > Signed-off-by: Anand Moon <moon.linux@yahoo.com>
> > ---
> 
> Oops.
> 
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
> 
> Can this be picked up?

It could be if I could find it.  Which is not the case, unfortunately.

Anybody care to resend it?

Rafael