From: Guodong Xu <guodong.xu@linaro.org>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: hi6421: Fix misleading comment
Date: Fri, 05 Sep 2014 17:16:55 +0800 [thread overview]
Message-ID: <54097F87.1030009@linaro.org> (raw)
In-Reply-To: <1409879666.5208.2.camel@phoenix>
Thanks. Could you also change the comments in macro defines, like here:
diff --git a/drivers/regulator/hi6421-regulator.c
b/drivers/regulator/hi6421-regulator.c
index e389920..156d0d1 100644
--- a/drivers/regulator/hi6421-regulator.c
+++ b/drivers/regulator/hi6421-regulator.c
@@ -37,7 +37,7 @@ struct hi6421_regulator_pdata {
* struct hi6421_regulator_info - hi6421 regulator information
* @desc: regulator description
* @mode_mask: ECO mode bitmask of LDOs; for BUCKs, this masks sleep
- * @eco_microamp: eco mode load upper limit (in mA), valid for LDOs only
+ * @eco_microamp: eco mode load upper limit (in uA), valid for LDOs only
*/
struct hi6421_regulator_info {
struct regulator_desc desc;
@@ -164,7 +164,7 @@ static const struct regulator_ops hi6421_buck345_ops;
* emask - enable mask
* odelay - off/on delay time in uS
* ecomask - eco mode mask
- * ecoamp - eco mode load uppler limit in mA
+ * ecoamp - eco mode load uppler limit in uA
*/
#define HI6421_LDO(_id, v_table, vreg, vmask, ereg, emask, \
odelay, ecomask, ecoamp) \
@@ -200,7 +200,7 @@ static const struct regulator_ops hi6421_buck345_ops;
* emask - enable mask
* odelay - off/on delay time in uS
* ecomask - eco mode mask
- * ecoamp - eco mode load uppler limit in mA
+ * ecoamp - eco mode load uppler limit in uA
*/
#define HI6421_LDO_LINEAR(_id, _min_uV, n_volt, vstep, vreg, vmask, \
ereg, emask, odelay, ecomask, ecoamp) \
@@ -237,7 +237,7 @@ static const struct regulator_ops hi6421_buck345_ops;
* emask - enable mask
* odelay - off/on delay time in uS
* ecomask - eco mode mask
- * ecoamp - eco mode load uppler limit in mA
+ * ecoamp - eco mode load uppler limit in uA
*/
#define HI6421_LDO_LINEAR_RANGE(_id, n_volt, volt_ranges, vreg, vmask, \
ereg, emask, odelay, ecomask, ecoamp) \
Thanks.
Best regards,
Guodong Xu
On 09/05/2014 09:14 AM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/hi6421-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/hi6421-regulator.c b/drivers/regulator/hi6421-regulator.c
> index e389920..a8c362c 100644
> --- a/drivers/regulator/hi6421-regulator.c
> +++ b/drivers/regulator/hi6421-regulator.c
> @@ -37,7 +37,7 @@ struct hi6421_regulator_pdata {
> * struct hi6421_regulator_info - hi6421 regulator information
> * @desc: regulator description
> * @mode_mask: ECO mode bitmask of LDOs; for BUCKs, this masks sleep
> - * @eco_microamp: eco mode load upper limit (in mA), valid for LDOs only
> + * @eco_microamp: eco mode load upper limit (in uA), valid for LDOs only
> */
> struct hi6421_regulator_info {
> struct regulator_desc desc;
>
next prev parent reply other threads:[~2014-09-05 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 1:14 [PATCH] regulator: hi6421: Fix misleading comment Axel Lin
2014-09-05 9:16 ` Guodong Xu [this message]
2014-09-05 10:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54097F87.1030009@linaro.org \
--to=guodong.xu@linaro.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox