From: "H. Peter Anvin" <hpa@zytor.com>
To: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
"maintainer:X86 ARCHITECTURE..." <x86@kernel.org>,
coreboot@coreboot.org
Subject: Re: [coreboot] [PATCH] x86: add coreboot framebuffer support
Date: Fri, 05 Sep 2014 14:20:07 -0700 [thread overview]
Message-ID: <540A2907.9080100@zytor.com> (raw)
In-Reply-To: <540A266F.80503@gmail.com>
On 09/05/2014 02:09 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>
>> I'm not a fan of Coreboot having invented its own nonstandard
>> hacks, but I guess it is pretty much unavoidable.
> It's completely avoidable. The stub can copy this information to
> standard framebuffer info structure. The only missing thing is to
> apply patch by cjwatson or mjg59 (I'm not sure now who wrote it)
> for having an ID for linear framebuffer which implies no specific
> hardware (it can be any) or firmware (coreboot doesn't provide nay
> additional info or callback).
>
> Please don't apply this patch it will break SeaBIOS booting with
> VGABIOS.
>
Thanks for the warning. Yes, this is the Right Thing.
-hpa
prev parent reply other threads:[~2014-09-05 21:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 10:25 [PATCH] x86: add coreboot framebuffer support Gerd Hoffmann
2014-09-05 20:05 ` H. Peter Anvin
2014-09-05 20:55 ` [coreboot] " ron minnich
2014-09-05 21:09 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-09-05 21:18 ` ron minnich
2014-09-05 21:23 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-09-05 21:31 ` H. Peter Anvin
2014-09-05 21:40 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-09-05 21:48 ` H. Peter Anvin
2014-09-09 6:15 ` Gerd Hoffmann
2014-09-05 21:20 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540A2907.9080100@zytor.com \
--to=hpa@zytor.com \
--cc=coreboot@coreboot.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=phcoder@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox