[GIT PULL] KVM changes for 3.17-rc4

[GIT PULL] KVM changes for 3.17-rc4

[Paolo Bonzini]

Linus,

The following changes since commit 30d1e0e806e5b2fadc297ba78f2d7afd6ba309cf:

  virt/kvm/assigned-dev.c: Set 'dev->irq_source_id' to '-1' after free it (2014-08-19 15:12:28 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus

for you to fetch changes up to b11ba8c62be3eba54784611c769f4d7d07fac4a5:

  KVM: x86: fix kvmclock breakage from timers branch merge (2014-09-04 23:42:11 +0200)

----------------------------------------------------------------
A smattering of bug fixes across most architectures.

The x86 fix is really working around a timekeeping bug that is being
exposed by KVM.  Thomas and John are aware of it and they are working
on the real fix.  I am including the workaround because I think it
makes the code nicer, so I would submit it sooner or later anyway.

----------------------------------------------------------------
Christian Borntraeger (4):
      KVM: s390: Fix user triggerable bug in dead code
      KVM: s390/mm: try a cow on read only pages for key ops
      KVM: s390/mm: Fix storage key corruption during swapping
      KVM: s390/mm: Fix guest storage key corruption in ptep_set_access_flags

Christoffer Dall (1):
      arm/arm64: KVM: Complete WFI/WFE instructions

Laurent Dufour (1):
      powerpc/kvm/cma: Fix panic introduces by signed shift operation

Paolo Bonzini (4):
      Merge tag 'kvm-s390-20140825' of git://git.kernel.org/.../kvms390/linux into kvm-master
      Merge tag 'kvm-arm-for-v3.17-rc3' of git://git.kernel.org/.../kvmarm/kvmarm into HEAD
      Merge tag 'kvm-s390-master-20140902' of git://git.kernel.org/.../kvms390/linux into kvm-master
      KVM: x86: fix kvmclock breakage from timers branch merge

Pranavkumar Sawargaonkar (1):
      ARM/ARM64: KVM: Nuke Hyp-mode tlbs before enabling MMU

 arch/arm/kvm/handle_exit.c          |  2 ++
 arch/arm/kvm/init.S                 |  4 ++++
 arch/arm64/kvm/handle_exit.c        |  2 ++
 arch/arm64/kvm/hyp-init.S           |  4 ++++
 arch/powerpc/kvm/book3s_64_mmu_hv.c |  4 ++--
 arch/s390/include/asm/pgtable.h     |  6 ++++--
 arch/s390/kvm/kvm-s390.c            | 13 -------------
 arch/s390/mm/pgtable.c              | 10 ++++++++++
 arch/x86/kvm/x86.c                  | 13 +++++++------
 9 files changed, 35 insertions(+), 23 deletions(-)

Re: [GIT PULL] KVM changes for 3.17-rc4

[Linus Torvalds]

On Fri, Sep 5, 2014 at 3:16 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus

Nothing new there. Forgot to push out, or perhaps to use "-f" to
overwrite the previous tag of the same name?

           Linus

Re: [GIT PULL] KVM changes for 3.17-rc4

[Thomas Gleixner]

On Fri, 5 Sep 2014, Linus Torvalds wrote:

> On Fri, Sep 5, 2014 at 3:16 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > are available in the git repository at:
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus
> 
> Nothing new there. Forgot to push out, or perhaps to use "-f" to
> overwrite the previous tag of the same name?

And even if there would be something, please do not pull the top most
commit b11ba8c62be3eb (KVM: x86: fix kvmclock breakage from timers
branch merge).

That one is blantanly wrong and just hacks badly around a brown
paperbag bug in the core timekeeping code, which I introduced in the
last overhaul.

It's debugged and understood. Fix is posted and if confirmed by the
KVM folks it will go to you before rc4.

Thanks,

	tglx

Re: [GIT PULL] KVM changes for 3.17-rc4

[Paolo Bonzini]

Il 05/09/2014 22:58, Thomas Gleixner ha scritto:
> Nothing new there. Forgot to push out, or perhaps to use "-f" to
> overwrite the previous tag of the same name?

It's there now.  Probably a --dry-run too much (I have
push=+refs/tags/for-linus:refs/tags/for-linus in the remote configuration).

> And even if there would be something, please do not pull the top most
> commit b11ba8c62be3eb (KVM: x86: fix kvmclock breakage from timers
> branch merge).
> 
> That one is blantanly wrong and just hacks badly around a brown
> paperbag bug in the core timekeeping code, which I introduced in the
> last overhaul.

It's not wrong, it's just different.  The commit message says clearly
that besides acting as a workaround, I find the patched code easier to
understand, and I clearly stated the same in the tag message.

Paolo

Re: [GIT PULL] KVM changes for 3.17-rc4

[Thomas Gleixner]

On Fri, 5 Sep 2014, Paolo Bonzini wrote:

> Il 05/09/2014 22:58, Thomas Gleixner ha scritto:
> > Nothing new there. Forgot to push out, or perhaps to use "-f" to
> > overwrite the previous tag of the same name?
> 
> It's there now.  Probably a --dry-run too much (I have
> push=+refs/tags/for-linus:refs/tags/for-linus in the remote configuration).
> 
> > And even if there would be something, please do not pull the top most
> > commit b11ba8c62be3eb (KVM: x86: fix kvmclock breakage from timers
> > branch merge).
> > 
> > That one is blantanly wrong and just hacks badly around a brown
> > paperbag bug in the core timekeeping code, which I introduced in the
> > last overhaul.
> 
> It's not wrong, it's just different.  The commit message says clearly

Right, it's different. Because you paper at the receiving end over a
core bug and that's wrong to begin with.

> that besides acting as a workaround, I find the patched code easier to
> understand, and I clearly stated the same in the tag message.

Well, we might have different opinions about easier to understand. I
did go a great length to distangle the monotonic boot time on which
you are interested from xtime, because the latter does not make any
sense outside of the core timekeeping code. Aside of that I optimized
the whole thing to avoid conversions, loops and hoops. So you just add
another multiply and add to make it more understandable. Sigh.

Thanks,

	tglx

Re: [GIT PULL] KVM changes for 3.17-rc4

[Paolo Bonzini]

Il 05/09/2014 23:24, Thomas Gleixner ha scritto:
> 
>> > that besides acting as a workaround, I find the patched code easier to
>> > understand, and I clearly stated the same in the tag message.
> Well, we might have different opinions about easier to understand. I
> did go a great length to distangle the monotonic boot time on which
> you are interested from xtime, because the latter does not make any
> sense outside of the core timekeeping code. Aside of that I optimized
> the whole thing to avoid conversions, loops and hoops. So you just add
> another multiply and add to make it more understandable. 

Fair enough, I've dropped the patch.

Thanks for helping out with the core timekeeping fix.

Paolo

Re: [GIT PULL] KVM changes for 3.17-rc4

[Thomas Gleixner]

On Fri, 5 Sep 2014, Paolo Bonzini wrote:

> Il 05/09/2014 23:24, Thomas Gleixner ha scritto:
> > 
> >> > that besides acting as a workaround, I find the patched code easier to
> >> > understand, and I clearly stated the same in the tag message.
> > Well, we might have different opinions about easier to understand. I
> > did go a great length to distangle the monotonic boot time on which
> > you are interested from xtime, because the latter does not make any
> > sense outside of the core timekeeping code. Aside of that I optimized
> > the whole thing to avoid conversions, loops and hoops. So you just add
> > another multiply and add to make it more understandable. 
> 
> Fair enough, I've dropped the patch.

Though I agree that the struct member name choice is not the most
brilliant one, so feel free to fix that.
 
> Thanks for helping out with the core timekeeping fix.

I'm still banging my head against the wall....