* [PATCH] xen/balloon: Remove unused pr_fmt() macro
@ 2014-09-08 13:23 Daniel Kiper
2014-09-08 13:26 ` David Vrabel
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Kiper @ 2014-09-08 13:23 UTC (permalink / raw)
To: linux-kernel, xen-devel
Cc: boris.ostrovsky, david.vrabel, konrad.wilk, Daniel Kiper
Remove unused pr_fmt() macro. Additionally, remove surplus empty
lines which left after earlier various fixes and cleanups.
Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
drivers/xen/balloon.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 5c660c7..08417b3 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -36,8 +36,6 @@
* IN THE SOFTWARE.
*/
-#define pr_fmt(fmt) "xen:" KBUILD_MODNAME ": " fmt
-
#include <linux/cpu.h>
#include <linux/kernel.h>
#include <linux/sched.h>
@@ -84,7 +82,6 @@ enum bp_state {
BP_ECANCELED
};
-
static DEFINE_MUTEX(balloon_mutex);
struct balloon_stats balloon_stats;
@@ -94,7 +91,6 @@ EXPORT_SYMBOL_GPL(balloon_stats);
static xen_pfn_t frame_list[PAGE_SIZE / sizeof(unsigned long)];
static DEFINE_PER_CPU(struct page *, balloon_scratch_page);
-
/* List of ballooned pages, threaded through the mem_map array. */
static LIST_HEAD(ballooned_pages);
@@ -616,7 +612,6 @@ static int alloc_balloon_scratch_page(int cpu)
return 0;
}
-
static int balloon_cpu_notify(struct notifier_block *self,
unsigned long action, void *hcpu)
{
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] xen/balloon: Remove unused pr_fmt() macro
2014-09-08 13:23 [PATCH] xen/balloon: Remove unused pr_fmt() macro Daniel Kiper
@ 2014-09-08 13:26 ` David Vrabel
2014-09-08 13:58 ` Daniel Kiper
0 siblings, 1 reply; 5+ messages in thread
From: David Vrabel @ 2014-09-08 13:26 UTC (permalink / raw)
To: Daniel Kiper, linux-kernel, xen-devel; +Cc: boris.ostrovsky, konrad.wilk
On 08/09/14 14:23, Daniel Kiper wrote:
> Remove unused pr_fmt() macro. Additionally, remove surplus empty
> lines which left after earlier various fixes and cleanups.
A patch in the 3.17 queue uses this.
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xen/balloon: Remove unused pr_fmt() macro
2014-09-08 13:26 ` David Vrabel
@ 2014-09-08 13:58 ` Daniel Kiper
2014-09-08 14:01 ` David Vrabel
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Kiper @ 2014-09-08 13:58 UTC (permalink / raw)
To: David Vrabel; +Cc: linux-kernel, xen-devel, boris.ostrovsky, konrad.wilk
On Mon, Sep 08, 2014 at 02:26:09PM +0100, David Vrabel wrote:
> On 08/09/14 14:23, Daniel Kiper wrote:
> > Remove unused pr_fmt() macro. Additionally, remove surplus empty
> > lines which left after earlier various fixes and cleanups.
>
> A patch in the 3.17 queue uses this.
Hmmm... Which one? I am not able to find anything relevant in xen/tip.
Am I missing something?
Daniel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xen/balloon: Remove unused pr_fmt() macro
2014-09-08 13:58 ` Daniel Kiper
@ 2014-09-08 14:01 ` David Vrabel
2014-09-08 14:27 ` Daniel Kiper
0 siblings, 1 reply; 5+ messages in thread
From: David Vrabel @ 2014-09-08 14:01 UTC (permalink / raw)
To: Daniel Kiper; +Cc: linux-kernel, xen-devel, boris.ostrovsky, konrad.wilk
On 08/09/14 14:58, Daniel Kiper wrote:
> On Mon, Sep 08, 2014 at 02:26:09PM +0100, David Vrabel wrote:
>> On 08/09/14 14:23, Daniel Kiper wrote:
>>> Remove unused pr_fmt() macro. Additionally, remove surplus empty
>>> lines which left after earlier various fixes and cleanups.
>>
>> A patch in the 3.17 queue uses this.
>
> Hmmm... Which one? I am not able to find anything relevant in xen/tip.
> Am I missing something?
The balloon driver already uses it. It is used in the pr_info() and
pr_warn() etc. macros.
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xen/balloon: Remove unused pr_fmt() macro
2014-09-08 14:01 ` David Vrabel
@ 2014-09-08 14:27 ` Daniel Kiper
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Kiper @ 2014-09-08 14:27 UTC (permalink / raw)
To: David Vrabel; +Cc: linux-kernel, xen-devel, boris.ostrovsky, konrad.wilk
On Mon, Sep 08, 2014 at 03:01:20PM +0100, David Vrabel wrote:
> On 08/09/14 14:58, Daniel Kiper wrote:
> > On Mon, Sep 08, 2014 at 02:26:09PM +0100, David Vrabel wrote:
> >> On 08/09/14 14:23, Daniel Kiper wrote:
> >>> Remove unused pr_fmt() macro. Additionally, remove surplus empty
> >>> lines which left after earlier various fixes and cleanups.
> >>
> >> A patch in the 3.17 queue uses this.
> >
> > Hmmm... Which one? I am not able to find anything relevant in xen/tip.
> > Am I missing something?
>
> The balloon driver already uses it. It is used in the pr_info() and
> pr_warn() etc. macros.
Ahhh... OK, I see. We override default macro definition in include/linux/printk.h.
So, forget about that patch. Sorry for confusion.
Daniel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-08 14:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-08 13:23 [PATCH] xen/balloon: Remove unused pr_fmt() macro Daniel Kiper
2014-09-08 13:26 ` David Vrabel
2014-09-08 13:58 ` Daniel Kiper
2014-09-08 14:01 ` David Vrabel
2014-09-08 14:27 ` Daniel Kiper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox