From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754565AbaIHTDh (ORCPT ); Mon, 8 Sep 2014 15:03:37 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:49496 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753956AbaIHTDe (ORCPT ); Mon, 8 Sep 2014 15:03:34 -0400 Message-ID: <540DFD8D.2020804@kernel.dk> Date: Mon, 08 Sep 2014 13:03:41 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Ming Lei , Christoph Hellwig CC: Linux Kernel Mailing List , Linux SCSI List Subject: Re: [PATCH 0/6] blk-mq: initialize pdu of flush req explicitly References: <1410079162-9872-1-git-send-email-ming.lei@canonical.com> <20140907184956.GB23026@lst.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/08/2014 10:55 AM, Ming Lei wrote: > On Mon, Sep 8, 2014 at 2:49 AM, Christoph Hellwig wrote: >> This works fine for me, although I still don't really like it very much. >> >> If you really want to go down the path of major surgery in this area we >> should probably allocate a flush request per hw_ctx, and initialize it >> using the normal init/exit functions. If we want to have proper multiqueue >> performance on devices needing flushes we'll need something like that anyway. > > Yes, that should be the final solution for the problem, and looks the whole > flush machinery need to move into hctx, I will try to figure out one patch to > do that. I had not thought of that, but seems like a great way to clean this up a lot. It just never felt like the right thing to do. -- Jens Axboe