public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nitin Kuppelur <nitinkuppelur@gmail.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: octeon-hcd: removed unwanted return from void functions
Date: Mon, 08 Sep 2014 21:09:14 +0200	[thread overview]
Message-ID: <540DFEDA.2060202@gmail.com> (raw)
In-Reply-To: <20140908185923.GA10550@drone.musicnaut.iki.fi>

Hi Aaro,

Thanks for review. I will correct the commit log length and resend the patch.

About the __cvmx_usb_perform_complete():
Here return statement has associated label. Due to which it will add
compilation warning. So I am not handling this.

Note:
Also checkpatch.pl does not complain about this.

Regards,
Nitin

> Please format line length to <= 76 characters in the commit log.
> 
> Maybe you could fix __cvmx_usb_perform_complete() as well?
> 
> A.
> 

  reply	other threads:[~2014-09-08 20:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08 17:13 [PATCH] Staging: octeon-hcd: removed unwanted return from void functions Nitin Kuppelur
2014-09-08 18:59 ` Aaro Koskinen
2014-09-08 19:09   ` Nitin Kuppelur [this message]
2014-09-08 19:28     ` [PATCH V2] Staging: octeon-hcd: removed unwanted return from void Nitin Kuppelur
2014-09-09  7:14     ` [PATCH] Staging: octeon-hcd: removed unwanted return from void functions Dan Carpenter
2014-09-08 19:33   ` Greg KH
2014-09-08 21:26     ` Aaro Koskinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540DFEDA.2060202@gmail.com \
    --to=nitinkuppelur@gmail.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox