From: Clemens Ladisch <clemens@ladisch.de>
To: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
x86@kernel.org, linux-kernel@vger.kernel.org,
vinod.koul@intel.com
Subject: Re: [PATCH] x86_64: Add memcpy32_toio to write to PCI MMIO
Date: Tue, 09 Sep 2014 10:01:18 +0200 [thread overview]
Message-ID: <540EB3CE.6010700@ladisch.de> (raw)
In-Reply-To: <1410164046-15577-1-git-send-email-subhransu.s.prusty@intel.com>
Subhransu S. Prusty wrote:
> This is needed because the hardware
Which hardware? Every x86-64 CPU ever built by AMD, Intel, and VIA?
> does not support 64-bit moveq insructions while writing to PCI MMIO.
> +#ifndef CONFIG_X86_64
> +#define MEMCPY_TOIO memcpy_toio
> +#else
> +#define MEMCPY_TOIO memcpy32_toio
> +#endif
This does not change any code that uses memcpy_toio().
> + for (i = 0; i < count/sizeof(u32); i++)
> + writel(*src_32++, dst_32++);
This breaks when count is not a multiple of four.
Regards,
Clemens
next prev parent reply other threads:[~2014-09-09 8:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 8:14 [PATCH] x86_64: Add memcpy32_toio to write to PCI MMIO Subhransu S. Prusty
2014-09-09 8:01 ` Clemens Ladisch [this message]
2014-09-16 15:29 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540EB3CE.6010700@ladisch.de \
--to=clemens@ladisch.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tglx@linutronix.de \
--cc=vinod.koul@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox