* [PATCH] Staging: octeon-hcd: removed dummy label
@ 2014-09-09 15:22 Nitin Kuppelur
2014-09-09 19:02 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Nitin Kuppelur @ 2014-09-09 15:22 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Nitin Kuppelur
This is a patch to the octeon-hcd.c file that
removes dummy label i.e. label followed by return of
void function
Signed-off-by: Nitin Kuppelur <nitinkuppelur@gmail.com>
---
drivers/staging/octeon-usb/octeon-hcd.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
index 8a80982..5fffef2 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -2253,9 +2253,8 @@ static void __cvmx_usb_perform_complete(
/* Increment to the next location in our packet array */
transaction->iso_packets++;
transaction->stage = CVMX_USB_STAGE_NON_CONTROL;
- goto done;
+ return;
}
- }
/* Remove the transaction from the pipe list */
list_del(&transaction->node);
@@ -2266,8 +2265,6 @@ static void __cvmx_usb_perform_complete(
transaction->actual_bytes,
transaction->urb);
kfree(transaction);
-done:
- return;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: octeon-hcd: removed dummy label
2014-09-09 15:22 [PATCH] Staging: octeon-hcd: removed dummy label Nitin Kuppelur
@ 2014-09-09 19:02 ` Dan Carpenter
2014-09-10 1:29 ` Nitin Kuppelur
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2014-09-09 19:02 UTC (permalink / raw)
To: Nitin Kuppelur; +Cc: gregkh, devel, linux-kernel
On Tue, Sep 09, 2014 at 05:22:19PM +0200, Nitin Kuppelur wrote:
> This is a patch to the octeon-hcd.c file that
> removes dummy label i.e. label followed by return of
> void function
>
> Signed-off-by: Nitin Kuppelur <nitinkuppelur@gmail.com>
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 8a80982..5fffef2 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2253,9 +2253,8 @@ static void __cvmx_usb_perform_complete(
> /* Increment to the next location in our packet array */
> transaction->iso_packets++;
> transaction->stage = CVMX_USB_STAGE_NON_CONTROL;
> - goto done;
> + return;
> }
> - }
>
Wat? Does this still compile without the curly brace?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: octeon-hcd: removed dummy label
2014-09-09 19:02 ` Dan Carpenter
@ 2014-09-10 1:29 ` Nitin Kuppelur
2014-09-10 1:36 ` [PATCH V2] " Nitin Kuppelur
0 siblings, 1 reply; 4+ messages in thread
From: Nitin Kuppelur @ 2014-09-10 1:29 UTC (permalink / raw)
To: Dan Carpenter; +Cc: gregkh, devel, linux-kernel
Hi Dan,
Sorry for that. While doing some last movement changes
related to indentation I accidentally removed the brace
and did not build it after :-(
I am sending PATCH with correction.
Regards,
Nitin
>
> Wat? Does this still compile without the curly brace?
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH V2] Staging: octeon-hcd: removed dummy label
2014-09-10 1:29 ` Nitin Kuppelur
@ 2014-09-10 1:36 ` Nitin Kuppelur
0 siblings, 0 replies; 4+ messages in thread
From: Nitin Kuppelur @ 2014-09-10 1:36 UTC (permalink / raw)
To: gregkh, dan.carpenter; +Cc: devel, linux-kernel, Nitin Kuppelur
This is a patch to the octeon-hcd.c file that fixes
removes dummy label i.e. label followed by return of
void function
Signed-off-by: Nitin Kuppelur <nitinkuppelur@gmail.com>
---
drivers/staging/octeon-usb/octeon-hcd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
index 8a80982..5f9db4c 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -2253,7 +2253,7 @@ static void __cvmx_usb_perform_complete(
/* Increment to the next location in our packet array */
transaction->iso_packets++;
transaction->stage = CVMX_USB_STAGE_NON_CONTROL;
- goto done;
+ return;
}
}
@@ -2266,8 +2266,6 @@ static void __cvmx_usb_perform_complete(
transaction->actual_bytes,
transaction->urb);
kfree(transaction);
-done:
- return;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-10 3:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-09 15:22 [PATCH] Staging: octeon-hcd: removed dummy label Nitin Kuppelur
2014-09-09 19:02 ` Dan Carpenter
2014-09-10 1:29 ` Nitin Kuppelur
2014-09-10 1:36 ` [PATCH V2] " Nitin Kuppelur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).