From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Greg KH <greg@kroah.com>
Cc: <linux-mips@linux-mips.org>,
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
<linux-next@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-serial@vger.kernel.org>
Subject: Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions
Date: Wed, 10 Sep 2014 09:25:09 +0100 [thread overview]
Message-ID: <54100AE5.6050401@imgtec.com> (raw)
In-Reply-To: <20140909191736.GA7467@kroah.com>
On 09/09/2014 08:17 PM, Greg KH wrote:
> On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote:
>> Commit e676253b19b2d269cccf67fdb1592120a0cd0676
>> (serial/8250: Add support for RS485 IOCTLs) added cases for the
>> TIOC{S,G}RS485 commands but this broke the build for MIPS:
>>
>> drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl':
>> drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSRS485' undeclared
>> (first use in this function)
>> drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared
>> (first use in this function)
>>
>> This patch adds these missing definitions
>>
>> Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>> Cc: <linux-next@vger.kernel.org>
>> Cc: <linux-kernel@vger.kernel.org>
>> Cc: <linux-serial@vger.kernel.org>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> ---
>> arch/mips/include/uapi/asm/ioctls.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/mips/include/uapi/asm/ioctls.h b/arch/mips/include/uapi/asm/ioctls.h
>> index b1e637757fe3..34050cb6b631 100644
>> --- a/arch/mips/include/uapi/asm/ioctls.h
>> +++ b/arch/mips/include/uapi/asm/ioctls.h
>> @@ -76,6 +76,8 @@
>>
>> #define TIOCSBRK 0x5427 /* BSD compatibility */
>> #define TIOCCBRK 0x5428 /* BSD compatibility */
>> +#define TIOCGRS485 0x542E
>> +#define TIOCSRS485 0x542F
>
> Any reason you aren't using the _IOR() type macros here?
>
> thanks,
>
> greg k-h
>
Hi Greg,
Not really. I am being consistent with what
include/uapi/asm-generic/ioctls.h is using, and with the xtensa patch
that was posted yesterday
https://lkml.org/lkml/2014/9/9/27
--
markos
next prev parent reply other threads:[~2014-09-10 8:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 11:52 [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions Markos Chandras
2014-09-09 19:17 ` Greg KH
2014-09-10 8:25 ` Markos Chandras [this message]
2014-09-10 8:39 ` Ricardo Ribalda Delgado
2014-09-10 8:45 ` Markos Chandras
2014-09-10 9:05 ` Ricardo Ribalda Delgado
2014-09-10 9:14 ` Markos Chandras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54100AE5.6050401@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox