From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753565AbaIKIoG (ORCPT ); Thu, 11 Sep 2014 04:44:06 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:59797 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753414AbaIKIoA (ORCPT ); Thu, 11 Sep 2014 04:44:00 -0400 Message-ID: <541160E8.5070701@ti.com> Date: Thu, 11 Sep 2014 11:44:24 +0300 From: Jyri Sarha User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Mike Turquette , , , , CC: , , Subject: Re: [PATCH] clk: add gpio gated clock References: <1409919694-26941-1-git-send-email-jsarha@ti.com> <20140909221408.19023.12081@quantum> In-Reply-To: <20140909221408.19023.12081@quantum> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/2014 01:14 AM, Mike Turquette wrote: > Quoting Jyri Sarha (2014-09-05 05:21:34) >> The added gpio-gate-clock is a basic clock that can be enabled and >> disabled trough a gpio output. The DT binding document for the clock >> is also added. For EPROBE_DEFER handling the registering of the clock >> has to be delayed until of_clk_get() call time. >> >> Signed-off-by: Jyri Sarha >> --- >> >> This is my final attempt to get this generic gpio controlled basic >> clock into mainline. Of course I gladly fix any issues that the patch >> may have. However, if there is no response, I give up and move it to TI >> specific clocks. >> > > I searched through my archives and found a post from January. You Cc'd > me as "". Note that the address is wrapped in > chevrons but there is no name string (e.g. "Mike Turquette"). > > My mailer doesn't parse this well it was not flagged as to:me in my > filters. Maybe other mailers handle this better? If you leave out the > name string in the future then it would probably be best to drop the > chevrons. > Then git send-email adds the chevrons, but in the future I'll put the name string there too. >> I've been sending this patch as a part of Beaglebone-Black HDMI audio >> patch series since last autumn. Since the previous version I have done >> some minor cleanups and changed the clock's compatible property from >> "gpio-clock" to "gpio-gate-clock". All the file names, comments, >> etc. have also been changed accordingly. > > Is your platform the only one to take advantage of this clock type so > far? I feel that it is esoteric enough that it shouldn't be made > generic. > > The main reason is that all of the generic clock types needs to be > overhauled at some point. E.g. the clk-gate should have its > machine-specific logic separated from its machine-independent logic. If > the gate clock were to populate .enable and .disable callbacks and then > leave the actual register banging, or regmap'ing, or gpio'ing up to your > backend driver then that would be a big improvement and would avoid the > need to create this new clock type outright. > > So that's on my todo list, but it's not done yet. For your patch I think > that putting this code into drivers/clk/ti would probably be best, > unless other folks could use it as-is. Even if others could use it today > I would want to remove it eventually for the reasons stated in the > paragraph above. > Ok, I see. I do not know of anybody else needing a gpio gate clock at the moment. I'll put the driver under drivers/clk/ti unless someone comes forward soon. Thanks, Jyri