Re: [PATCH v5 4/7] kvm, mem-hotplug: Reload L1' apic access page on migration in vcpu_enter_guest().

Paolo Bonzini
2014-09-11T10:39:30Z

Il 11/09/2014 12:20, tangchen ha scritto:
>>>
>>> + vmcs_write64(APIC_ACCESS_ADDR, hpa);
>> This has to be guarded by "if (!is_guest_mode(vcpu))".
>
> Since we cannot get vcpu through kvm, I'd like to move this check to
> vcpu_reload_apic_access_page() when
> kvm_x86_ops->set_apic_access_page_addr()
> is called.

Good idea! Though passing the vcpu to vmx_set_apic_access_page_addr
would also work.

Paolo