From: micky <micky_ching@realsil.com.cn>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <sameo@linux.intel.com>, <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>, <wei_wang@realsil.com.cn>,
<devel@linuxdriverproject.org>, <rogerable@realtek.com>,
<lee.jones@linaro.org>
Subject: Re: [PATCH 1/2] mfd: rtsx: fix PM suspend for 5227
Date: Fri, 12 Sep 2014 16:43:06 +0800 [thread overview]
Message-ID: <5412B21A.6050808@realsil.com.cn> (raw)
In-Reply-To: <20140912083627.GX6600@mwanda>
On 09/12/2014 04:36 PM, Dan Carpenter wrote:
> You've updated them all to be "if (err < 0)" how is that different from
> "if (err)"? What I'm saying is that could you reply to the question?
>
> I guess I normally prefer "if (err)" over "if (err < 0)" but I don't
> know if it makes a difference here?
Hi Dan,
these function never return positive value, but other part of the driver
code
use (err < 0), I use (err < 0) here for consistency.
(err) and (err < 0) is same at least for these function called here.
Best Regards.
micky.
next prev parent reply other threads:[~2014-09-12 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 7:17 [PATCH 0/2] mfd: rtsx: fix PM suspend for 5227 & 5249 micky_ching
2014-09-11 7:17 ` [PATCH 1/2] mfd: rtsx: fix PM suspend for 5227 micky_ching
2014-09-11 7:42 ` Dan Carpenter
2014-09-12 8:36 ` Dan Carpenter
2014-09-12 8:43 ` micky [this message]
2014-09-11 7:17 ` [PATCH 2/2] mfd: rtsx: fix PM suspend for 5249 micky_ching
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5412B21A.6050808@realsil.com.cn \
--to=micky_ching@realsil.com.cn \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox