From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: <robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <plagnioj@jcrosoft.com>,
<grant.likely@linaro.org>, <arnd@arndb.de>,
<peter.griffin@linaro.org>, <jg1.han@samsung.com>,
<daniel.vetter@ffwll.ch>, <laurent.pinchart@ideasonboard.com>,
<robdclark@gmail.com>, <linux-fbdev@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fbdev: fsl-sii902x: HDMI support for Freescale SoCs
Date: Fri, 12 Sep 2014 12:34:17 +0300 [thread overview]
Message-ID: <5412BE19.2010302@ti.com> (raw)
In-Reply-To: <1409892517-29816-1-git-send-email-Li.Xiubo@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]
Hi,
On 05/09/14 07:48, Xiubo Li wrote:
> Some Freescale SoCs, there has an DVI/HDMI controller and a PHY,
> attached to one of their display controller unit's LCDC interfaces.
> This patch adds a preliminary static support for such controllers.
>
> This will support for many modes and a dynamic switching between
> them.
>
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
> .../devicetree/bindings/video/fsl-sii902x.txt | 17 +
> drivers/video/fbdev/Kconfig | 7 +
> drivers/video/fbdev/Makefile | 1 +
> drivers/video/fbdev/fsl-sii902x.c | 526 +++++++++++++++++++++
> 4 files changed, 551 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/video/fsl-sii902x.txt
> create mode 100644 drivers/video/fbdev/fsl-sii902x.c
I don't know how you picked the names of the people you sent this patch
to, but looks to me that most of them are probably not interested in
this patch.
Anyway, a few quick comments on the patch:
- You should probably use regmap instead of direct i2c calls.
Interestingly, you define regmap variable, but you never use it.
- Use defines for register offsets, instead of magic numbers.
- You should not use static variables. They prevent having multiple
instances of the device.
So the SiI902x chip is on the SoC, not on the board? And it's a plain
standard SiI902x in other aspects?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-12 9:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 4:48 [PATCH] fbdev: fsl-sii902x: HDMI support for Freescale SoCs Xiubo Li
2014-09-12 9:34 ` Tomi Valkeinen [this message]
2014-09-15 2:17 ` Li.Xiubo
2014-09-19 13:45 ` Tomi Valkeinen
2014-09-24 6:45 ` Li.Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5412BE19.2010302@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=Li.Xiubo@freescale.com \
--cc=arnd@arndb.de \
--cc=daniel.vetter@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jg1.han@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=peter.griffin@linaro.org \
--cc=plagnioj@jcrosoft.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox