From: Jianqun <xjq@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>, Jianqun <jay.xu@rock-chips.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.de, grant.likely@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, huangtao@rock-chips.com,
cf@rock-chips.com
Subject: Re: [PATCH 1/2] ASoC: rockchip-max98090: add documentation for rockchip-max98090 driver
Date: Fri, 12 Sep 2014 18:12:10 +0800 [thread overview]
Message-ID: <5412C6FA.9020308@rock-chips.com> (raw)
In-Reply-To: <3774516.jOvxH1lgyQ@diego>
在 09/12/2014 06:04 PM, Heiko Stübner 写道:
> Hi Jianqun,
>
> Am Freitag, 12. September 2014, 17:10:55 schrieb Jianqun:
>> Add documentation for rockchip-max98090 driver, which is need by rockchip
>> board using a max98090.
>>
>> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
>> ---
>> changes since v1:
>
> please make sure to also include the version in the patch subject, so that
> people can always see which is which. This one should've been
>
> [PATCH v2 1/2] ASoC: rockchip-max98090: add documentation for rockchip-max98090 driver
>
> Because without this identification, people can only try to guess which one is the
> newest version.
>
ok, thanks, I will notice this in the future
>
> Heiko
>
>> - modify error text from "Tegra" to "rockchip"
>>
>> .../sound/rockchip,rockchip-audio-max98090.txt | 23
>> ++++++++++++++++++++++ 1 file changed, 23 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/sound/rockchip,rockchip-audio-max98090.tx
>> t
>>
>> diff --git
>> a/Documentation/devicetree/bindings/sound/rockchip,rockchip-audio-max98090.
>> txt
>> b/Documentation/devicetree/bindings/sound/rockchip,rockchip-audio-max98090.
>> txt new file mode 100644
>> index 0000000..e12d1a0
>> --- /dev/null
>> +++
>> b/Documentation/devicetree/bindings/sound/rockchip,rockchip-audio-max98090.
>> txt @@ -0,0 +1,23 @@
>> +ROCKCHIP audio complex, with MAX98090 CODEC
>> +
>> +Required properties:
>> +- compatible : must be "rockchip,rockchip-audio-max98090"
>> +- rockchip,model : the user-visible name of this sound complex
>> +- rockchip,i2s-controller : The phandle of the rockchip I2S controller
>> + that's connected to the CODEC.
>> +- rockchip,audio-codec : The phandle of the MAX98090 audio codec.
>> +
>> +Optional properties:
>> +- rockchip,hp-det-gpios : The GPIO that detect headphones are plugged in
>> +- rockchip,mic-det-gpios : The GPIO that detect micphones are plugged in
>> +
>> +Example:
>> +
>> +sound {
>> + compatible = "rockchip,rockchip-audio-max98090";
>> + rockchip,model = "ROCKCHIP-I2S";
>> + rockchip,i2s-controller = <&i2s>;
>> + rockchip,audio-codec = <&max98090>;
>> + rockchip,hp-det-gpios = <&gpio6 5 GPIO_ACTIVE_HIGH>;
>> + rockchip,mic-det-gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
>> +};
>
>
>
>
next prev parent reply other threads:[~2014-09-12 10:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 7:26 [PATCH 0/2] rockchip-max98090: add driver for rockchip board with max98090 Jianqun
2014-09-12 7:30 ` [PATCH 1/2] ASoC: rockchip-max98090: add documentation for rockchip-max98090 driver Jianqun
2014-09-12 9:10 ` Jianqun
2014-09-12 10:04 ` Heiko Stübner
2014-09-12 10:12 ` Jianqun [this message]
2014-09-12 13:44 ` Mark Brown
2014-09-28 0:54 ` Jianqun
2014-09-28 10:48 ` Mark Brown
2014-09-28 11:05 ` Jianqun
2014-09-12 7:32 ` [PATCH 2/2] ASoC: rockchip-max98090: add driver for rockchip board using a max98090 Jianqun
2014-09-12 7:39 ` [PATCH] " Jianqun
2014-09-12 13:52 ` Mark Brown
2014-10-02 8:06 ` Jianqun
2014-09-12 7:43 ` [PATCH 2/2] " Jianqun
2014-10-02 8:36 ` [PATCH v2 " Jianqun
2014-10-02 10:22 ` Mark Brown
2014-09-12 13:42 ` [PATCH 0/2] rockchip-max98090: add driver for rockchip board with max98090 Mark Brown
2014-09-14 3:00 ` Jianqun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5412C6FA.9020308@rock-chips.com \
--to=xjq@rock-chips.com \
--cc=broonie@kernel.org \
--cc=cf@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jay.xu@rock-chips.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox