From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753291AbaILKp4 (ORCPT ); Fri, 12 Sep 2014 06:45:56 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:47402 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751629AbaILKpx (ORCPT ); Fri, 12 Sep 2014 06:45:53 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68f-f797f6d000001173-89-5412cedf16d5 Content-transfer-encoding: 8BIT Message-id: <5412CEDF.7030806@samsung.com> Date: Fri, 12 Sep 2014 19:45:51 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 To: Andrzej Hajda Cc: "moderated list:ARM/S5P EXYNOS AR..." , Seung-Woo Kim , open list , dri-devel@lists.freedesktop.org, Kyungmin Park , Marek Szyprowski Subject: Re: [PATCH 5/9] drm/exynos/crtc: fix framebuffer reference sequence References: <1410268573-2297-1-git-send-email-a.hajda@samsung.com> <1410268573-2297-6-git-send-email-a.hajda@samsung.com> <5412B02A.6040609@samsung.com> <20140912085710.GD4740@phenom.ffwll.local> <5412BC8D.2030007@samsung.com> In-reply-to: <5412BC8D.2030007@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKIsWRmVeSWpSXmKPExsWyRsSkWPf+OaEQg9VbFC1urTvHanHl63s2 i7NNb9gtLu+aw2Yx4/w+Jou1R+6yW8yY/JLNgd3jfvdxJo++LasYPT5vkgtgjuKySUnNySxL LdK3S+DKmPRrBVtBr1bF9PlnGRsYNyl3MXJySAiYSMw5tYQdwhaTuHBvPRuILSSwlFFixvSg LkYOsJpvT3m7GLmAwtMZJdo73jGD1PAKCEr8mHyPBaSGWUBe4silbJAws4C6xKR5i5gh6l8x Sqw53cIIUa8lceNmDzNIPYuAqsS13iSQMBuQOXHFfbC1ogJhEi9e7QIbLwI0Z/bJO2BzmAUW MEkcebAXrEhYwEfiwNWd7BB3vmCUeLNEEmQmp4C2RH8vB0i9hMAxdokJXx4xgdSwCAhIfJt8 iAXiF1mJTQeYId6VlDi44gbLBEaxWUi+mYXwzSwk3yxgZF7FKJpakFxQnJReZKxXnJhbXJqX rpecn7uJERhbp/8969/BePeA9SFGAQ5GJR7eChbBECHWxLLiytxDjKZAR0xklhJNzgdGcF5J vKGxmZGFqYmpsZG5pZmSOO9CqZ/BQgLpiSWp2ampBalF8UWlOanFhxiZODilGhhtPeoq7K85 53+dnWekVnC/ZreS0wLx6Ktzc38alt5acvGew7onm9sU7+QzZ2w8ZzAp4Zu3SuyR3rxWNXHV pRxbtjy0mrBHxaBBTuP39CB3Ka3z6p3qd77mT5348JB4a0+1Xv1jDfEgt3dBT+WKypk/qcpU zXggdTfpkq2S13kJfT7WYvVTh5RYijMSDbWYi4oTAaA5ad6oAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsVy+t9jQd3754RCDJ48krC4te4cq8WVr+/Z LM42vWG3uLxrDpvFjPP7mCzWHrnLbjFj8ks2B3aP+93HmTz6tqxi9Pi8SS6AOaqB0SYjNTEl tUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaLuSQlliTilQKCCx uFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCGMWPSrxVsBb1aFdPnn2VsYNyk3MXIwSEhYCLx 7SlvFyMnkCkmceHeerYuRi4OIYHpjBLtHe+YQRK8AoISPybfYwGpZxaQlzhyKRskzCygLjFp 3iJmiPpXjBJrTrcwQtRrSdy42cMMUs8ioCpxrTcJJMwGZE5ccZ8NxBYVCJN48WoX2HgRoDmz T94Bm8MssIBJ4siDvWBFwgI+Egeu7mQHsYUEXjBKvFkiCTKTU0Bbor+XYwKjwCwk181CuG4W kusWMDKvYhRNLUguKE5KzzXSK07MLS7NS9dLzs/dxAiO3WfSOxhXNVgcYhTgYFTi4a1kEQwR Yk0sK67MPcQowcGsJMJrflQoRIg3JbGyKrUoP76oNCe1+BCjKdBvE5mlRJPzgWklryTe0NjE zMjSyNzQwsjYXEmc92CrdaCQQHpiSWp2ampBahFMHxMHp1QDo0/Kptnt93Zv72nMX6OtUVrw J/nIaSt2/3OcketqJ4ns9np3sT5lw+bTKY1P62Xfni9c8DaCd8baBDvjjR+9TW3fL/TykPhh /2yd/AmuQ5c2VGtz6X3fr7Urt++ix84bx31a7nAcOrOsIvRo4km1xMurtjz7a1TI765x23DW zaQbc/puuLYsvKfEUpyRaKjFXFScCABKnf/18wIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014년 09월 12일 18:27, Andrzej Hajda wrote: > On 09/12/2014 10:57 AM, Daniel Vetter wrote: >> On Fri, Sep 12, 2014 at 05:34:50PM +0900, Inki Dae wrote: >>> Hi Andrzej, >>> >>> On 2014년 09월 09일 22:16, Andrzej Hajda wrote: >>>> Adding reference to framebuffer should be accompanied with removing >>>> reference to old framebuffer assigned to the plane. >>>> This patch removes following warning: >>>> >>>> [ 95.038017] WARNING: CPU: 1 PID: 3067 at drivers/gpu/drm/drm_crtc.c:5115 drm_mode_config_cleanup+0x258/0x268() >>>> [ 95.048086] Modules linked in: >>>> [ 95.051430] CPU: 1 PID: 3067 Comm: bash Tainted: G W 3.16.0-11355-g7a6eca5-dirty #3015 >>>> [ 95.060058] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) >>>> [ 95.067766] [] (show_stack) from [] (dump_stack+0x70/0xbc) >>>> [ 95.074953] [] (dump_stack) from [] (warn_slowpath_common+0x64/0x88) >>>> [ 95.083005] [] (warn_slowpath_common) from [] (warn_slowpath_null+0x1c/0x24) >>>> [ 95.091780] [] (warn_slowpath_null) from [] (drm_mode_config_cleanup+0x258/0x268) >>>> [ 95.100983] [] (drm_mode_config_cleanup) from [] (exynos_drm_unload+0x38/0x50) >>>> [ 95.109915] [] (exynos_drm_unload) from [] (drm_dev_unregister+0x24/0x98) >>>> [ 95.118414] [] (drm_dev_unregister) from [] (drm_put_dev+0x28/0x64) >>>> [ 95.126412] [] (drm_put_dev) from [] (take_down_master+0x24/0x44) >>>> [ 95.134218] [] (take_down_master) from [] (component_del+0x8c/0xc8) >>>> [ 95.142201] [] (component_del) from [] (exynos_dsi_remove+0x18/0x2c) >>>> [ 95.150294] [] (exynos_dsi_remove) from [] (platform_drv_remove+0x18/0x1c) >>>> [ 95.158872] [] (platform_drv_remove) from [] (__device_release_driver+0x70/0xc4) >>>> [ 95.167981] [] (__device_release_driver) from [] (device_release_driver+0x20/0x2c) >>>> [ 95.177268] [] (device_release_driver) from [] (unbind_store+0x5c/0x94) >>>> [ 95.185597] [] (unbind_store) from [] (drv_attr_store+0x20/0x2c) >>>> [ 95.193323] [] (drv_attr_store) from [] (sysfs_kf_write+0x4c/0x50) >>>> [ 95.201224] [] (sysfs_kf_write) from [] (kernfs_fop_write+0xc4/0x184) >>>> [ 95.209393] [] (kernfs_fop_write) from [] (vfs_write+0xa0/0x1a8) >>>> [ 95.217111] [] (vfs_write) from [] (SyS_write+0x40/0x8c) >>>> [ 95.224146] [] (SyS_write) from [] (ret_fast_syscall+0x0/0x48) >>>> >>>> Signed-off-by: Andrzej Hajda >>>> --- >>>> drivers/gpu/drm/exynos/exynos_drm_crtc.c | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c >>>> index b68e58f..bde19f4 100644 >>>> --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c >>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c >>>> @@ -145,10 +145,16 @@ exynos_drm_crtc_mode_set(struct drm_crtc *crtc, struct drm_display_mode *mode, >>>> if (ret) >>>> return ret; >>>> >>>> + /* we need to unreference current fb after replacing it with new one */ >>>> + old_fb = plane->fb; >>>> + >>>> plane->crtc = crtc; >>>> plane->fb = crtc->primary->fb; >>>> drm_framebuffer_reference(plane->fb); >>>> >>>> + if (old_fb) >>>> + drm_framebuffer_unreference(old_fb); >>> This time would be a good chance that we can consider drm flip queue to >>> make sure that whole memory region to old_fb is scanned out completely >>> before dropping a reference of old_fb. the reference of old_fb should be >>> dropped at irq handler of each crtc devices, fimd and mixer. >> Generally it's not a good idea to drop fb references from irq context, >> since if you actually drop the last reference it'll blow up: fb cleanup >> needs a bunch of mutexes. > > I agree with that. > >> >> Also the drm core really should be taking care of this for you, you only >> need to grab references yourself for async flips if you want the buffer to >> survive a bit. crtc_mode_set has not need for this. I expect that the >> refcounting bug is somewhere else, at least from my experience chasing >> such issues in i915 ;-) > > Hmm, maybe I miss something but I do not see the core grabbing fb reference > on plane->fb update. On the other side drm_framebuffer_remove calls > drm_plane_force_disable which drops plane->fb reference. > I am not yet familiar with this code so maybe there is better solution. > > If not I guess it would be better to move this code to > exynos_plane_mode_set. > At least it is done this way in omap and msm, in fact it seems better place I cannot see it in msm. In case of msm, drm flip queue is used in mdp4/5_crtc_mode_set function. See update_fb function there. > for such things. What do you think? > > Regards > Andrzej > >> -Daniel > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >