From: mark <yzq@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>, "Mark yao" <mark.yao@rock-chips.com>
Cc: Mike Turquette <mturquette@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
djkurtz@chromium.org, dianders@chromium.org, dkl@rock-chips.com,
eddie.cai@rock-chips.com, xjq@rock-chips.com, kfx@rock-chips.com,
huangtao@rock-chips.com, zyw@rock-chips.com, yxj@rock-chips.com,
cym@rock-chips.com, zhengsq@rock-chips.com,
caesar.wang@rock-chips.com, kever.yang@rock-chips.com
Subject: Re: [PATCH] clk: rockchip: rk3288: add VOP1 softresets and rename VOP0 softresets
Date: Fri, 12 Sep 2014 19:01:47 +0800 [thread overview]
Message-ID: <5412D29B.8000600@rock-chips.com> (raw)
In-Reply-To: <3298686.YKlhYtF9M9@diego>
On 2014年09月12日 18:41, Heiko Stübner wrote:
> Hi Mark,
>
> Am Freitag, 12. September 2014, 18:33:23 schrieb Mark yao:
>> The rk3288 have two vop, and each vop has three softresets were axi_reset,
>> ahb_reset and dclk_reset.
> I'm not sure about renaming the indices, since they're part of the devicetree-
> binding. We know that so far no device in the wild used them, so it might be
> ok.
now vop driver need these reset, so we need add it.
> But in any case could you also add the rest of the indices of the "new" reset
> registers please, so that we don't end up adding each small index in a
> separate patch.
>
> patch1: add reset indices for SOFTRST9 - SOFTRST11
> patch2: rename LCDC0 -> VOP0
OK, I will do it
>
> Heiko
>
>> Signed-off-by: Mark yao <mark.yao@rock-chips.com>
>> ---
>> include/dt-bindings/clock/rk3288-cru.h | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/dt-bindings/clock/rk3288-cru.h
>> b/include/dt-bindings/clock/rk3288-cru.h index ebcb460..4d65959 100644
>> --- a/include/dt-bindings/clock/rk3288-cru.h
>> +++ b/include/dt-bindings/clock/rk3288-cru.h
>> @@ -235,9 +235,9 @@
>> #define SRST_RGA_NIU 97
>> #define SRST_VIO0_NIU_AXI 98
>> #define SRST_VIO_NIU_AHB 99
>> -#define SRST_LCDC0_AXI 100
>> -#define SRST_LCDC0_AHB 101
>> -#define SRST_LCDC0_DCLK 102
>> +#define SRST_VOP0_AXI 100
>> +#define SRST_VOP0_AHB 101
>> +#define SRST_VOP0_DCLK 102
>> #define SRST_VIO1_NIU_AXI 103
>> #define SRST_VIP 104
>> #define SRST_RGA_CORE 105
>> @@ -276,3 +276,7 @@
>> #define SRST_USBHOST1_CON 140
>> #define SRST_USB_ADP 141
>> #define SRST_ACC_EFUSE 142
>> +
>> +#define SRST_VOP1_AXI 176
>> +#define SRST_VOP1_AHB 177
>> +#define SRST_VOP1_DCLK 178
>
>
>
prev parent reply other threads:[~2014-09-12 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 10:33 [PATCH] clk: rockchip: rk3288: add VOP1 softresets and rename VOP0 softresets Mark yao
2014-09-12 10:41 ` Heiko Stübner
2014-09-12 11:01 ` mark [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5412D29B.8000600@rock-chips.com \
--to=yzq@rock-chips.com \
--cc=caesar.wang@rock-chips.com \
--cc=cym@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dkl@rock-chips.com \
--cc=eddie.cai@rock-chips.com \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kever.yang@rock-chips.com \
--cc=kfx@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mark.yao@rock-chips.com \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=xjq@rock-chips.com \
--cc=yxj@rock-chips.com \
--cc=zhengsq@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox