From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@canonical.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 2/9] block: introduce blk_init_flush and its pair
Date: Fri, 12 Sep 2014 09:45:15 -0600 [thread overview]
Message-ID: <5413150B.9010803@kernel.dk> (raw)
In-Reply-To: <CACVXFVOrWaaga=3NWeWs400AL4CS316jBftngxmjS4L-YGKkYQ@mail.gmail.com>
On 2014-09-12 09:41, Ming Lei wrote:
> On Fri, Sep 12, 2014 at 11:18 PM, Jens Axboe <axboe@kernel.dk> wrote:
>> On 2014-09-12 08:47, Ming Lei wrote:
>>>
>>> These two functions are introduced to initialize and de-initialize
>>> flush stuff centrally.
>>
>>
>> I know you said these change later to more proper naming, but that only
>> happens further down. Lets get rid of these wrappers and just call
>> blk_alloc_flush_queue() directly.
>
> It is too early to call blk_alloc_flush_queue() because flush queue doesn't
> come until patch 5 appears, :-) And I think it is cleaner to put
> flush initialization
> stuff together first, then introduce flush_queue.
Then do it later. Fact is, final result still looks like this in
blk_mq_init_queue():
if (blk_init_flush(q))
...
where it would be cleaner as just assigning q->fq. My previous (and
existing) point is that you have no idea what this init_flush() function
does without jumping in and reading it.
--
Jens Axboe
next prev parent reply other threads:[~2014-09-12 15:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 14:47 [PATCH v2 0/9] block: per-distpatch_queue flush machinery Ming Lei
2014-09-12 14:47 ` [PATCH v2 1/9] blk-mq: allocate flush_rq in blk_mq_init_flush() Ming Lei
2014-09-12 14:47 ` [PATCH v2 2/9] block: introduce blk_init_flush and its pair Ming Lei
2014-09-12 15:18 ` Jens Axboe
2014-09-12 15:41 ` Ming Lei
2014-09-12 15:45 ` Jens Axboe [this message]
2014-09-12 15:59 ` Ming Lei
2014-09-12 14:47 ` [PATCH v2 3/9] block: move flush initialization to blk_flush_init Ming Lei
2014-09-12 14:47 ` [PATCH v2 4/9] block: avoid to use q->flush_rq directly Ming Lei
2014-09-12 14:47 ` [PATCH v2 5/9] block: introduce blk_flush_queue to drive flush machinery Ming Lei
2014-09-12 14:47 ` [PATCH v2 6/9] block: flush: avoid to figure out flush queue unnecessarily Ming Lei
2014-09-12 14:47 ` [PATCH v2 7/9] block: introduce 'blk_mq_ctx' parameter to blk_get_flush_queue Ming Lei
2014-09-12 14:47 ` [PATCH v2 8/9] blk-mq: handle failure path for initializing hctx Ming Lei
2014-09-12 15:19 ` Jens Axboe
2014-09-12 14:47 ` [PATCH v2 9/9] blk-mq: support per-distpatch_queue flush machinery Ming Lei
2014-09-12 15:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5413150B.9010803@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox