From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751675AbaILR0X (ORCPT ); Fri, 12 Sep 2014 13:26:23 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:55289 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbaILR0V (ORCPT ); Fri, 12 Sep 2014 13:26:21 -0400 Message-ID: <54132CBC.6030003@codeaurora.org> Date: Fri, 12 Sep 2014 10:26:20 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Rob Herring CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , linux-arm-msm , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH/RESEND] tty: serial: msm: Add DT based earlycon support References: <1410473644-19103-1-git-send-email-sboyd@codeaurora.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/14 18:56, Rob Herring wrote: > On Thu, Sep 11, 2014 at 5:14 PM, Stephen Boyd wrote: >> Add support for DT based early console on platforms with the msm >> serial hardware. >> >> Cc: Rob Herring >> Signed-off-by: Stephen Boyd > One comment, but looks good to me. > > Acked-by: Rob Herring Thanks. >> +static int __init >> +msm_serial_early_console_setup(struct earlycon_device *device, const char *opt) >> +{ >> + if (!device->port.membase) >> + return -ENODEV; >> + >> + device->con->write = msm_serial_early_write; >> + return 0; >> +} >> +OF_EARLYCON_DECLARE(msm_serial, "qcom,msm-uart", >> + msm_serial_early_console_setup); > Don't you want to support kernel command line as well? Then if you > can't change the DT or bootloader's command line, you can add it into > the kernel build with the appended command line. Don't forget to > document it in kernel-parameters.txt if you do. > > Ok. Here's the interdiff. I'll send a v2. ---8<---- diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 5ae8608ca9f5..22302931e9d4 100644 --- a/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt @@ -936,6 +936,18 @@ bytes respectively. Such letter suffixes can also be entirely omitted. must already be setup and configured. Options are not yet supported. + msm_serial, + Start an early, polled-mode console on an msm serial + port at the specified address. The serial port + must already be setup and configured. Options are not + yet supported. + + msm_serial_dm, + Start an early, polled-mode console on an msm serial + dm port at the specified address. The serial port + must already be setup and configured. Options are not + yet supported. + smh Use ARM semihosting calls for early console. earlyprintk= [X86,SH,BLACKFIN,ARM,M68k] diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index d3881991e8d3..4b6c78331a64 100644 --- a/drivers/tty/serial/msm_serial.c +++ b/drivers/tty/serial/msm_serial.c @@ -976,6 +976,7 @@ msm_serial_early_console_setup(struct earlycon_device *device, const char *opt) device->con->write = msm_serial_early_write; return 0; } +EARLYCON_DECLARE(msm_serial, msm_serial_early_console_setup); OF_EARLYCON_DECLARE(msm_serial, "qcom,msm-uart", msm_serial_early_console_setup); @@ -997,6 +998,7 @@ msm_serial_early_console_setup_dm(struct earlycon_device *device, device->con->write = msm_serial_early_write_dm; return 0; } +EARLYCON_DECLARE(msm_serial_dm, msm_serial_early_console_setup_dm); OF_EARLYCON_DECLARE(msm_serial_dm, "qcom,msm-uartdm", msm_serial_early_console_setup_dm); -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation