Re: [PATCHv4 00/12] usb: dwc2: Add support for dual role

[Dinh Nguyen <dinguyen@opensource.altera.com>]

On 09/12/2014 11:44 AM, Bartlomiej Zolnierkiewicz wrote:
> 
> [ added linux-kernel ML to cc: ]
> 
> Hi,
> 
> On Tuesday, August 26, 2014 11:19:51 AM dinguyen@opensource.altera.com wrote:
>> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>>
>> Hello,
>>
>> This is version 4 of the patch series that combines the dwc2 gadget and host
>> driver into a single dual role driver. Here are the main differences from V2:
>>
>> - Patch 9/12 : Move spin_lock_init() earlier up in the function to guarantee
>>   no locks can be taken before the initializing the spin_lock.
>>
>> - Patch 12/12 : Same as patch 9/12.
>>
>> - Added Acked-by: paulz for all patches except patch 9/12 and 12/12.
>>
>> For v4, I have rebased the series on top of Greg KH's USB usb-linus tree
>> [9b2667f usb: dwc2: gadget: Set the default EP max packet value as 8 bytes]
>> and on top of the following patches that have not yet been applied:
>>
>> Doug Anderson: usb: dwc2: Read GNPTXFSIZ when in forced HOST mode
>> Kever Yang : usb: dwc2: add 'mode' which based on Kconfig select or dts setting
>> Robert Baldyga : usb: dwc2/gadget: fix series <- 12 patches
>>
>> As usual, tested on SOCFPGA(host, gadget, and dual-role) and on Rpi-B
>> (host mode only).
>>
>> I have pushed this series to a git repo to make it more convenient for people
>> to test/review.
>>
>> git://git.rocketboards.org/linux-socfpga-next.git dwc2_dual_role_v4
> 
> Please also add linux-kernel ML to next revision of the patchset
> (helps to get reviewers).
> 
> Also sorry for the late review but people are not yet used to
> the fact that dwc2 now also means "our" good old s3c-hsotg. ;-)
> 

Thanks for the review. I'll try to address all of your comments in the
next version.

Dinh