From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Phillip Potter <phil@philpotter.co.uk>
Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
dan.carpenter@oracle.com
Subject: Re: [RFC PATCH] staging: r8188eu: Use completions instead of semaphores
Date: Sat, 16 Oct 2021 08:59:27 +0200 [thread overview]
Message-ID: <5414235.RPW7nLbG7U@localhost.localdomain> (raw)
In-Reply-To: <YWm/x56aX+rNOlE0@equinox>
On Friday, October 15, 2021 7:52:07 PM CEST Phillip Potter wrote:
>
> Dear Fabio,
>
> Sounds like a good approach to me, nice work.
Dear Phil,
Thanks for the "good job". These words always sound very rewarding :)
Please read my reply to Dan's message. I have decided to go through a
different approach and make two patches for the semaphores => condition
variables and a third for removing a duplicate 'if' statement in that
rtw_cmd_thread() where now we have the semaphores.
As I wrote in that reply, I hope that you and Dan agree with me on this
different approach to fix rtw_cmd_thread().
Thanks,
Fabio
> I agree with Dan's
> feedback also - will wait for the final patchset then give it a test for
> you :-) Apologies I've been a little on the quiet side as of late.
P.S.: No need to apologize at all :)
I had noticed that you haven't been around for a while. I would have
appreciated a review from you (and Larry) on the series of 32 patches that
Pavel Skripkin and I co-developed and submitted some weeks ago.
However, I am 100% sure that you really had some important reasons for not
being here.
>
> Regards,
> Phil
>
next prev parent reply other threads:[~2021-10-16 6:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 11:02 [RFC PATCH] staging: r8188eu: Use completions instead of semaphores Fabio M. De Francesco
2021-10-15 11:37 ` Dan Carpenter
2021-10-15 12:11 ` Fabio M. De Francesco
2021-10-15 12:50 ` Dan Carpenter
2021-10-16 6:43 ` Fabio M. De Francesco
2021-10-16 7:12 ` Dan Carpenter
2021-10-15 17:52 ` Phillip Potter
2021-10-16 6:59 ` Fabio M. De Francesco [this message]
2021-10-16 14:33 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5414235.RPW7nLbG7U@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox