From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752648AbaINOXi (ORCPT ); Sun, 14 Sep 2014 10:23:38 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:43633 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752526AbaINOXg (ORCPT ); Sun, 14 Sep 2014 10:23:36 -0400 Message-ID: <5415A4DF.90706@redhat.com> Date: Sun, 14 Sep 2014 16:23:27 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Ard Biesheuvel , Andrew Morton CC: kvm@vger.kernel.org, Christoffer Dall , linux-mm@kvack.org, linux-s390@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-mips@linux-mips.org, ralf@linux-mips.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com Subject: Re: [PATCH] mm: export symbol dependencies of is_zero_pfn() References: <1410553043-575-1-git-send-email-ard.biesheuvel@linaro.org> <20140912141429.17d570d1a7e1cb99ec73f0f7@linux-foundation.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 12/09/2014 23:19, Ard Biesheuvel ha scritto: > On 12 September 2014 23:14, Andrew Morton wrote: >> On Fri, 12 Sep 2014 22:17:23 +0200 Ard Biesheuvel wrote: >> >>> In order to make the static inline function is_zero_pfn() callable by >>> modules, export its symbol dependencies 'zero_pfn' and (for s390 and >>> mips) 'zero_page_mask'. >> >> So hexagon and score get the export if/when needed. >> > > Exactly. > >>> We need this for KVM, as CONFIG_KVM is a tristate for all supported >>> architectures except ARM and arm64, and testing a pfn whether it refers >>> to the zero page is required to correctly distinguish the zero page >>> from other special RAM ranges that may also have the PG_reserved bit >>> set, but need to be treated as MMIO memory. >>> >>> Signed-off-by: Ard Biesheuvel >>> --- >>> arch/mips/mm/init.c | 1 + >>> arch/s390/mm/init.c | 1 + >>> mm/memory.c | 2 ++ >> >> Looks OK to me. Please include the patch in whichever tree is is that >> needs it, and merge it up via that tree. >> > > Thanks. > > @Paolo: could you please take this (with Andrew's ack), and put it > before the patch you took earlier today? Yes, will do. Paolo