linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Looijmans <mike.looijmans@topic.nl>
To: <f.fainelli@gmail.com>, <netdev@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, Mike Looijmans <mike.looijmans@topic.nl>
Subject: Re: [PATCH v3] net/phy: micrel: Disable asymmetric pause for KSZ9031
Date: Mon, 15 Sep 2014 12:07:42 +0200	[thread overview]
Message-ID: <5416BA6E.4080507@topic.nl> (raw)
In-Reply-To: <1410775594-3129-1-git-send-email-mike.looijmans@topic.nl>

I based this patch on the 3.17rc5 state. Hope this applies cleanly now?


On 09/15/2014 12:06 PM, Mike Looijmans wrote:
> The KSZ9031 appears to suffer from the same hardware bug as described
> for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577
> ("net/phy: micrel: Disable asymmetric pause for KSZ9021")
> you have to unplug the cable and plug it back to get it to work.
>
> Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
>   drivers/net/phy/micrel.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index fd0ea7c..011dbda 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -592,8 +592,7 @@ static struct phy_driver ksphy_driver[] = {
>   	.phy_id		= PHY_ID_KSZ9031,
>   	.phy_id_mask	= 0x00fffff0,
>   	.name		= "Micrel KSZ9031 Gigabit PHY",
> -	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause
> -				| SUPPORTED_Asym_Pause),
> +	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause),
>   	.flags		= PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT,
>   	.config_init	= ksz9031_config_init,
>   	.config_aneg	= genphy_config_aneg,
>



Met vriendelijke groet / kind regards,

Mike Looijmans

TOPIC Embedded Systems
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: (+31) (0) 499 33 69 79
Telefax:  (+31) (0) 499 33 69 70
E-mail: mike.looijmans@topic.nl
Website: www.topic.nl

Please consider the environment before printing this e-mail

Topic zoekt gedreven (embedded) software specialisten!
http://topic.nl/vacatures/topic-zoekt-software-engineers/


  reply	other threads:[~2014-09-15 10:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11 13:45 [PATCH] net/phy: micrel: Disable asymmetric pause for KSZ9031 Mike Looijmans
2014-09-11 18:41 ` Florian Fainelli
2014-09-12  6:54   ` Mike Looijmans
2014-09-12 12:40   ` [PATCH v2] " Mike Looijmans
2014-09-12 22:18     ` David Miller
2014-09-15  7:44       ` Mike Looijmans
2014-09-15 10:06       ` [PATCH v3] " Mike Looijmans
2014-09-15 10:07         ` Mike Looijmans [this message]
2014-09-15 18:24         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5416BA6E.4080507@topic.nl \
    --to=mike.looijmans@topic.nl \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).