Re: [PATCH v3 2/4] ARM: dts: pbab01: enable I2S audio on phyFLEX-i.MX6 boards

Fabio Estevam
2014-10-01T12:11:17Z

On Tue, Sep 16, 2014 at 5:08 AM, Dmitry Lavnikevich
<d.lavnikevich@sam-solutions.com> wrote:

> + regulators {
> + sound_1v8: regulator@2 {

We usually start counting from @0.

> + compatible = "regulator-fixed";
> + reg = <2>;
> + regulator-name = "i2s-audio-1v8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;

No need to have this 'regulator-always-on'

> + };
> +
> + sound_3v3: regulator@3 {

,so this one should be @1.

> + compatible = "regulator-fixed";
> + reg = <3>;
> + regulator-name = "i2s-audio-3v3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;

No need to have this 'regulator-always-on'

> +&ssi2 {
> + fsl,mode = "i2s-slave";

Please remove this 'fsl,mode' property. It is ignored by the fsl_ssi driver.