From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753248AbaIOOHv (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Sep 2014 10:07:51 -0400
Received: from bhuna.collabora.co.uk ([93.93.135.160]:38896 "EHLO
	bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753077AbaIOOHt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Sep 2014 10:07:49 -0400
Message-ID: <5416F2B2.1060300@collabora.co.uk>
Date: Mon, 15 Sep 2014 16:07:46 +0200
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0
MIME-Version: 1.0
To: Andrew Morton <akpm@linux-foundation.org>
CC: Alessandro Zummo <a.zummo@towertech.it>,
        Doug Anderson <dianders@chromium.org>, Olof Johansson <olof@lixom.net>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        rtc-linux@googlegroups.com, linux-samsung-soc@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH RESEND v9 5/5] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock
References: <1410509864-10019-1-git-send-email-javier.martinez@collabora.co.uk>	<1410509864-10019-6-git-send-email-javier.martinez@collabora.co.uk> <20140912151334.cd53fca611a7de487f23241b@linux-foundation.org>
In-Reply-To: <20140912151334.cd53fca611a7de487f23241b@linux-foundation.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Andrew,

On 09/13/2014 12:13 AM, Andrew Morton wrote:
> On Fri, 12 Sep 2014 10:17:43 +0200 Javier Martinez Canillas <javier.martinez@collabora.co.uk> wrote:
> 
>> The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
>> This patch adds support for the RTC and is based on a driver
>> added by Simon Glass to the Chrome OS kernel 3.8 tree.
>> 
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> Would it be appropriate to gather Simon's signoff?
> 

I don't know. The original driver written by Simon supported 2 devices:
max77686 and max77802. I split the max77802 bits and addressed all the issues
pointed out on early revisions so even when Simon is mentioned as the
MODULE_AUTHOR(), I didn't know if he would like his s-o-b to remain in the
patch since it was quite different than the original one from which was based.

>> +static inline int max77802_rtc_calculate_wday(u8 shifted)
>> +{
>> +	int counter = -1;
>> +
>> +	while (shifted) {
>> +		shifted >>= 1;
>> +		counter++;
>> +	}
> 
> Can't use log2() or similar?
> 

Yes, ffs() - 1 can be used instead of this function indeed.

I see that you already included this patch to your -mm tree [0]. Does it mean
that I've to send a follow-up patch on top of this to remove this function or
should I send a new version of this patch?

Best regards,
Javier

[0]:
http://ozlabs.org/~akpm/mmots/broken-out/rtc-add-driver-for-maxim-77802-pmic-real-time-clock.patch