From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754668AbaIOTPm (ORCPT ); Mon, 15 Sep 2014 15:15:42 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:45327 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754633AbaIOTP3 (ORCPT ); Mon, 15 Sep 2014 15:15:29 -0400 Message-ID: <54173ACA.1010709@ti.com> Date: Mon, 15 Sep 2014 14:15:22 -0500 From: Nishanth Menon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Jim Davis , Stephen Rothwell , linux-next , linux-kernel , Dmitry Torokhov , Subject: Re: randconfig build error with next-20140915, in drivers/input/misc/palmas-pwrbutton.c References: <5417222E.30201@ti.com> In-Reply-To: <5417222E.30201@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/15/2014 12:30 PM, Nishanth Menon wrote: > On 09/15/2014 09:40 AM, Jim Davis wrote: >> Building with the attached random configuration file, >> >> FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol >> 'platform_driver_unregister' >> make[1]: *** [__modpost] Error 1 >> > For some reason, I was unable to reproduce this in my build with ARM > OMAP5 configuration... but with the x86 configuration, I was. > > https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?h=next&id=adff5962fdd2f29bac943bc014ebd529444b2153 > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n101 > > I used MODULE_LICENSE("GPL V2") > > Looks like a typo crept in. And s/V/v seems to squelch the warning(at > least in the x86 build) for the randconfig. I will post a patch > accordingly. Thanks for catching the same. > > diff --git a/drivers/input/misc/palmas-pwrbutton.c > b/drivers/input/misc/palmas-pwrbutton.c > index 3f90211..06ffe04 100644 > --- a/drivers/input/misc/palmas-pwrbutton.c > +++ b/drivers/input/misc/palmas-pwrbutton.c > @@ -326,5 +326,5 @@ module_platform_driver(palmas_pwron_driver); > > MODULE_ALIAS("platform:palmas-pwrbutton"); > MODULE_DESCRIPTION("Palmas Power Button"); > -MODULE_LICENSE("GPL V2"); > +MODULE_LICENSE("GPL v2"); > MODULE_AUTHOR("Texas Instruments Inc."); > To close this thread, posted: https://patchwork.kernel.org/patch/4907121/ -- Regards, Nishanth Menon