From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756800AbaIOVrh (ORCPT ); Mon, 15 Sep 2014 17:47:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24132 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754380AbaIOVrd (ORCPT ); Mon, 15 Sep 2014 17:47:33 -0400 Message-ID: <54175E4F.2030200@redhat.com> Date: Mon, 15 Sep 2014 23:46:55 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Will Deacon CC: Catalin Marinas , "davem@davemloft.net" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Zi Shen Lim , Alexei Starovoitov Subject: Re: [PATCH arm64-next v3] net: bpf: arm64: address randomize and write protect JIT code References: <1410812423-11818-1-git-send-email-dborkman@redhat.com> <20140915213004.GA31150@arm.com> In-Reply-To: <20140915213004.GA31150@arm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/15/2014 11:30 PM, Will Deacon wrote: > Hi Daniel, > > One small comment than I forgot to mention before (see below). > > On Mon, Sep 15, 2014 at 09:20:23PM +0100, Daniel Borkmann wrote: >> This is the ARM64 variant for 314beb9bcab ("x86: bpf_jit_comp: secure bpf >> jit against spraying attacks"). >> >> Thanks to commit 11d91a770f1f ("arm64: Add CONFIG_DEBUG_SET_MODULE_RONX >> support") which added necessary infrastructure, we can now implement >> RO marking of eBPF generated JIT image pages and randomize start offset >> for the JIT code, so that it does not reside directly on a page boundary >> anymore. Likewise, the holes are filled with illegal instructions: here >> we use BRK #0x100 (opcode 0xd4202000) to trigger a fault in the kernel >> (unallocated BRKs would trigger a fault through do_debug_exception). This >> seems more reliable as we don't have a guaranteed undefined instruction >> space on ARM64. >> >> This is basically the ARM64 variant of what we already have in ARM via >> commit 55309dd3d4cd ("net: bpf: arm: address randomize and write protect >> JIT code"). Moreover, this commit also presents a merge resolution due to >> conflicts with commit 60a3b2253c41 ("net: bpf: make eBPF interpreter images >> read-only") as we don't use kfree() in bpf_jit_free() anymore to release >> the locked bpf_prog structure, but instead bpf_prog_unlock_free() through >> a different allocator. >> >> JIT tested on aarch64 with BPF test suite. >> >> Reference: http://mainisusuallyafunction.blogspot.com/2012/11/attacking-hardened-linux-systems-with.html >> Signed-off-by: Daniel Borkmann >> Cc: Zi Shen Lim >> Cc: Will Deacon >> Cc: Catalin Marinas >> Cc: David S. Miller >> Cc: Alexei Starovoitov >> --- >> v2->v3: >> - Use cpu_to_le32() as suggested by Zi/Will >> v1->v2: >> - Use brk insn as suggested by Catalin >> Note: >> - This patch depends on net-next being merged to mainline due >> to the mentioned merge conflict. >> >> arch/arm64/net/bpf_jit_comp.c | 38 +++++++++++++++++++++++++++++--------- >> 1 file changed, 29 insertions(+), 9 deletions(-) >> >> diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c >> index 7ae3354..4b71779 100644 >> --- a/arch/arm64/net/bpf_jit_comp.c >> +++ b/arch/arm64/net/bpf_jit_comp.c >> @@ -19,7 +19,6 @@ >> #define pr_fmt(fmt) "bpf_jit: " fmt >> >> #include >> -#include >> #include >> #include >> #include >> @@ -119,6 +118,15 @@ static inline int bpf2a64_offset(int bpf_to, int bpf_from, >> return to - from; >> } >> >> +static void jit_fill_hole(void *area, unsigned int size) >> +{ >> + /* We use brk #0x100 to trigger a fault. */ >> + u32 *ptr; >> + /* We are guaranteed to have aligned memory. */ >> + for (ptr = area; size >= sizeof(u32); size -= sizeof(u32)) >> + *ptr++ = cpu_to_le32(0xd4202000); >> +} > > Please can you use the existing macros in debug-monitors.h for constructing > this value? We have AARCH64_BREAK_MON to get the BRK encoding, then you can > add an immediate to that file to reserve something for bpf. That way, we > make sure that other parts of the kernel don't accidentally repurpose your > fault code. Okay, no problem, I'll do that and respin tomorrow. Thanks, Daniel