From: Keith Owens <kaos@sgi.com>
To: prasanna@in.ibm.com
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org,
Andrew Morton <akpm@osdl.org>,
ak@muc.de, suparna@in.ibm.com
Subject: Re: [1/2] PATCH Kernel watchpoint interface-2.6.9-rc4-mm1
Date: Mon, 18 Oct 2004 19:22:08 +1000 [thread overview]
Message-ID: <5418.1098091328@ocs3.ocs.com.au> (raw)
In-Reply-To: Your message of "Mon, 18 Oct 2004 14:15:25 +0530." <20041018084525.GA27936@in.ibm.com>
On Mon, 18 Oct 2004 14:15:25 +0530,
Prasanna S Panchamukhi <prasanna@in.ibm.com> wrote:
>This patch provides global debug register settings.
>Used by kernel watchpoint interface patch.
>+config DEBUGREG
>+ bool "Global Debug Registers"
>+ depends on DEBUG_KERNEL
>+ help
>+ Global debug register settings will be honoured if this is turned on.
>+ If in doubt, say "N".
>+
I like most of the patch, but Kconfig is wrong. This option should not
be exposed to end users, instead CONFIG_DEBUGREG should be selected by
the debug code that calls debugreg. IOW, kgdb, kdb or kwatch select
debugreg, not the other way around.
next prev parent reply other threads:[~2004-10-18 9:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-18 8:43 [0/2] PATCH Kernel watchpoint interface-2.6.9-rc4-mm1 Prasanna S Panchamukhi
2004-10-18 8:45 ` [1/2] " Prasanna S Panchamukhi
2004-10-18 8:46 ` [2/2] " Prasanna S Panchamukhi
2004-10-22 6:40 ` Prasanna S Panchamukhi
2004-10-18 9:22 ` Keith Owens [this message]
2004-10-18 12:46 ` [1/2] " Andi Kleen
2004-10-22 6:15 ` Prasanna S Panchamukhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5418.1098091328@ocs3.ocs.com.au \
--to=kaos@sgi.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
--cc=suparna@in.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox