public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] extcon: sm5502: Depend on I2C
@ 2014-09-16 16:51 Jean Delvare
  0 siblings, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2014-09-16 16:51 UTC (permalink / raw)
  To: MyungJoo Ham, Chanwoo Choi; +Cc: linux-kernel

The SM5502 chip is an I2C device so its drivers must depend on I2C.
Failing to do so results in build failures on kernels where I2C is
not enabled.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
---
 drivers/extcon/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -72,6 +72,7 @@ config EXTCON_PALMAS
 
 config EXTCON_SM5502
 	tristate "SM5502 EXTCON support"
+	depends on I2C
 	select IRQ_DOMAIN
 	select REGMAP_I2C
 	select REGMAP_IRQ

-- 
Jean Delvare
SUSE L3 Support


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] extcon: sm5502: Depend on I2C
@ 2014-09-16 23:39 MyungJoo Ham
  2014-09-16 23:41 ` Randy Dunlap
  0 siblings, 1 reply; 3+ messages in thread
From: MyungJoo Ham @ 2014-09-16 23:39 UTC (permalink / raw)
  To: Jean Delvare, 최찬우; +Cc: linux-kernel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 843 bytes --]

> The SM5502 chip is an I2C device so its drivers must depend on I2C.
> Failing to do so results in build failures on kernels where I2C is
> not enabled.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

> ---
>  drivers/extcon/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -72,6 +72,7 @@ config EXTCON_PALMAS
>  
>  config EXTCON_SM5502
>  	tristate "SM5502 EXTCON support"
> +	depends on I2C
>  	select IRQ_DOMAIN
>  	select REGMAP_I2C
>  	select REGMAP_IRQ
> 
> -- 
> Jean Delvare
> SUSE L3 Support
> 
> 
> 
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] extcon: sm5502: Depend on I2C
  2014-09-16 23:39 [PATCH] extcon: sm5502: Depend on I2C MyungJoo Ham
@ 2014-09-16 23:41 ` Randy Dunlap
  0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2014-09-16 23:41 UTC (permalink / raw)
  To: myungjoo.ham, Jean Delvare, 최찬우; +Cc: linux-kernel

On 09/16/14 16:39, MyungJoo Ham wrote:
>> The SM5502 chip is an I2C device so its drivers must depend on I2C.
>> Failing to do so results in build failures on kernels where I2C is
>> not enabled.
>>
>> Signed-off-by: Jean Delvare <jdelvare@suse.de>
>> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> 
> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Geert sent this same patch.  I sent this same patch.
What happened to those patches?


> 
>> ---
>>  drivers/extcon/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- a/drivers/extcon/Kconfig
>> +++ b/drivers/extcon/Kconfig
>> @@ -72,6 +72,7 @@ config EXTCON_PALMAS
>>  
>>  config EXTCON_SM5502
>>  	tristate "SM5502 EXTCON support"
>> +	depends on I2C
>>  	select IRQ_DOMAIN
>>  	select REGMAP_I2C
>>  	select REGMAP_IRQ
>>
>> -- 
>> Jean Delvare
>> SUSE L3 Support


-- 
~Randy

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-16 23:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-16 23:39 [PATCH] extcon: sm5502: Depend on I2C MyungJoo Ham
2014-09-16 23:41 ` Randy Dunlap
  -- strict thread matches above, loose matches on Subject: below --
2014-09-16 16:51 Jean Delvare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox