From: Paolo Bonzini <pbonzini@redhat.com>
To: Tang Chen <tangchen@cn.fujitsu.com>,
gleb@kernel.org, mtosatti@redhat.com, nadav.amit@gmail.com,
jan.kiszka@web.de
Cc: kvm@vger.kernel.org, laijs@cn.fujitsu.com,
isimatu.yasuaki@jp.fujitsu.com, guz.fnst@cn.fujitsu.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 4/6] kvm, mem-hotplug: Reload L1' apic access page on migration in vcpu_enter_guest().
Date: Wed, 17 Sep 2014 11:14:54 +0200 [thread overview]
Message-ID: <5419510E.2090404@redhat.com> (raw)
In-Reply-To: <541942B5.6000907@cn.fujitsu.com>
Il 17/09/2014 10:13, Tang Chen ha scritto:
>
>
>> Please add a new function kvm_arch_mmu_notifier_invalidate_page, and
>> call it outside the mmu_lock.
>
> Then I think we need a macro to control the calling of this arch function
> since other architectures do not have it.
You can add an inline function that does nothing. There are other examples.
>> kvm_reload_apic_access_page need not be in virt/kvm/kvm_main.c, either.
>
> Since kvm_reload_apic_access_page() only calls make_all_cpus_request(),
> and make_all_cpus_request() is static, I'd like to make it non-static, rename
> it to kvm_make_all_cpus_request() and call it directly in kvm_arch_mmu_notifier_invalidate_page().
> we don't need kvm_reload_apic_access_page() actually.
Ok.
Paolo
next prev parent reply other threads:[~2014-09-17 9:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 10:41 [PATCH v6 0/6] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page Tang Chen
2014-09-16 10:41 ` [PATCH v6 1/6] kvm: Use APIC_DEFAULT_PHYS_BASE macro as the apic access page address Tang Chen
2014-09-16 10:41 ` [PATCH v6 2/6] kvm: Remove ept_identity_pagetable from struct kvm_arch Tang Chen
2014-09-16 10:41 ` [PATCH v6 3/6] kvm: Make init_rmode_identity_map() return 0 on success Tang Chen
2014-09-16 10:42 ` [PATCH v6 4/6] kvm, mem-hotplug: Reload L1' apic access page on migration in vcpu_enter_guest() Tang Chen
2014-09-16 11:24 ` Paolo Bonzini
2014-09-17 8:13 ` Tang Chen
2014-09-17 9:14 ` Paolo Bonzini [this message]
2014-09-16 10:42 ` [PATCH v6 5/6] kvm, mem-hotplug: Reload L1's apic access page on migration when L2 is running Tang Chen
2014-09-16 11:34 ` Paolo Bonzini
2014-09-16 10:42 ` [PATCH v6 6/6] kvm, mem-hotplug: Unpin and remove kvm_arch->apic_access_page Tang Chen
2014-09-16 11:44 ` [PATCH v6 0/6] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5419510E.2090404@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@kernel.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=nadav.amit@gmail.com \
--cc=tangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).