From: Martin Kelly <martin@martingkelly.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: x86@kernel.org, mingo@redhat.com, vishwesh.m.rudramuni@intel.com,
joe@perches.com, hpa@linux.intel.com, aubrey.li@linux.intel.com,
linux-kernel@vger.kernel.org, Martin Kelly <martkell@amazon.com>
Subject: Re: [PATCH v2] x86/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n
Date: Wed, 17 Sep 2014 07:19:22 -0700 [thread overview]
Message-ID: <5419986A.9000302@martingkelly.com> (raw)
In-Reply-To: <20140917122427.GB2704@gmail.com>
On 09/17/2014 05:24 AM, Ingo Molnar wrote:
>
> Just to paint the bike shed a bit, this could be further
> simplified to something like:
>
> ...
>
> ret = pmc_dbgfs_register(pmc, pdev);
> if (ret)
> iounmap(pmc->regmap);
>
> return ret;
>
> and then your patch will be perfect! :-)
>
Yes, good idea. I sent a v3 with that implemented.
prev parent reply other threads:[~2014-09-17 14:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 0:49 [PATCH v2] x86/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n Martin Kelly
2014-09-17 2:09 ` Li, Aubrey
2014-09-17 3:20 ` Martin Kelly
2014-09-17 3:44 ` Li, Aubrey
2014-09-17 4:04 ` Martin Kelly
2014-09-17 12:24 ` Ingo Molnar
2014-09-17 14:19 ` Martin Kelly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5419986A.9000302@martingkelly.com \
--to=martin@martingkelly.com \
--cc=aubrey.li@linux.intel.com \
--cc=hpa@linux.intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martkell@amazon.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=vishwesh.m.rudramuni@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox