public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@sr71.net>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
	hpa@linux.intel.com, ak@linux.intel.com,
	Alex Chiang <achiang@hp.com>, Borislav Petkov <bp@suse.de>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Mike Travis <travis@sgi.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH] x86: Consider multiple nodes in a single socket to be "sane"
Date: Wed, 17 Sep 2014 17:33:12 -0700	[thread overview]
Message-ID: <541A2848.6030308@sr71.net> (raw)
In-Reply-To: <20140917225726.GH2848@worktop.localdomain>

On 09/17/2014 03:57 PM, Peter Zijlstra wrote:
>> > Another option would be to:
>> > 1. Add a new "PKG" level and actually _build_ it with phys_proc_id
>> > 2. Make sure to tie the sysfs 'core_siblings' file to PKG
>> > 3. Leave the "MC" level as it is now, but define it as being the lowest-
>> >    common-denominator of core grouping.  In other words, the "MC" group
>> >    will stop at a NUMA node or a socket boundary, whichever it sees
>> >    first.
>> > 4. Chop the "COD_NUMA" level off in sched_init_numa()
> No, we should provide an arch override for sched_domain_topology which
> has the right setup for the detected topology.
> 
> See arm,powerpc and s390, which already have his.

I _think_ the problem here is that all of the existing topologies
describe something below the smallest NUMA node.  With the
cluster-on-die stuff, we've got a node boundary smack in the middle of
the existing topology levels.

So, if we're going to do this with a new sched_domain_topology, we've
got to make sure that we eliminate all of the levels below that first
NUMA node.  I think that means just have a topology with the SMT level
alone in it.

Does that work?



  reply	other threads:[~2014-09-18  0:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-15 22:26 [PATCH] x86: Consider multiple nodes in a single socket to be "sane" Dave Hansen
2014-09-16  3:29 ` Peter Zijlstra
2014-09-16  6:38   ` Chuck Ebbert
2014-09-16  6:44     ` Ingo Molnar
2014-09-16  7:03       ` Chuck Ebbert
2014-09-16  7:05         ` Ingo Molnar
2014-09-16 16:01         ` Peter Zijlstra
2014-09-16 16:46           ` Dave Hansen
2014-09-16 15:59       ` Peter Zijlstra
2014-09-16 16:36         ` Dave Hansen
2014-09-16  8:17   ` Dave Hansen
2014-09-16 10:07     ` Heiko Carstens
2014-09-16 17:58     ` Peter Zijlstra
2014-09-16 23:49       ` Dave Hansen
2014-09-17 22:57         ` Peter Zijlstra
2014-09-18  0:33           ` Dave Hansen [this message]
2014-09-17 12:55     ` Borislav Petkov
2014-09-18  7:32       ` Borislav Petkov
2014-09-16 16:59   ` Brice Goglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541A2848.6030308@sr71.net \
    --to=dave@sr71.net \
    --cc=achiang@hp.com \
    --cc=ak@linux.intel.com \
    --cc=bp@suse.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rusty@rustcorp.com.au \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox