From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756030AbaIRHTo (ORCPT ); Thu, 18 Sep 2014 03:19:44 -0400 Received: from mga01.intel.com ([192.55.52.88]:40420 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751149AbaIRHTn (ORCPT ); Thu, 18 Sep 2014 03:19:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,545,1406617200"; d="scan'208";a="478364184" Message-ID: <541A8698.9040905@intel.com> Date: Thu, 18 Sep 2014 15:15:36 +0800 From: Lan Tianyu User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: paulmck@linux.vnet.ibm.com CC: linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com, "Rafael J. Wysocki" Subject: Re: [PATCH RFC tip/core/rcu] Eliminate deadlock between CPU hotplug and expedited grace periods References: <20140828194745.GA3761@linux.vnet.ibm.com> <5419342E.60602@intel.com> <20140917131013.GU4723@linux.vnet.ibm.com> In-Reply-To: <20140917131013.GU4723@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014年09月17日 21:10, Paul E. McKenney wrote: > On Wed, Sep 17, 2014 at 03:11:42PM +0800, Lan Tianyu wrote: >> On 2014年08月29日 03:47, Paul E. McKenney wrote: >>> Currently, the expedited grace-period primitives do get_online_cpus(). >>> This greatly simplifies their implementation, but means that calls to >>> them holding locks that are acquired by CPU-hotplug notifiers (to say >>> nothing of calls to these primitives from CPU-hotplug notifiers) can >>> deadlock. But this is starting to become inconvenient: >>> https://lkml.org/lkml/2014/8/5/754 >>> >>> This commit avoids the deadlock and retains the simplicity by creating >>> a try_get_online_cpus(), which returns false if the get_online_cpus() >>> reference count could not immediately be incremented. If a call to >>> try_get_online_cpus() returns true, the expedited primitives operate >>> as before. If a call returns false, the expedited primitives fall back >>> to normal grace-period operations. This falling back of course results >>> in increased grace-period latency, but only during times when CPU >>> hotplug operations are actually in flight. The effect should therefore >>> be negligible during normal operation. >>> >>> Signed-off-by: Paul E. McKenney >>> Cc: Josh Triplett >>> Cc: "Rafael J. Wysocki" >>> Cc: Lan Tianyu >> >> Hi Paul: >> What's the status of the patch? Will you push it? Thanks. > > By default, it would go into 3.19. Do you need it earlier? IMO, this is a dead lock bug which is hard to reproduce and the patch should go into v3.17 and stable tree? > > Thanx, Paul > -- Best regards Tianyu Lan