From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757172AbaIRKBd (ORCPT ); Thu, 18 Sep 2014 06:01:33 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:52064 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757134AbaIRKBb (ORCPT ); Thu, 18 Sep 2014 06:01:31 -0400 Message-ID: <541AAD9F.9070504@linaro.org> Date: Thu, 18 Sep 2014 15:32:07 +0530 From: Sanjay Singh Rawat User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Zhang Rui CC: edubezval@gmail.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org Subject: Re: [PATCH] thermal: show supported policies References: <1410865062-28995-1-git-send-email-sanjay.rawat@linaro.org> <1411001832.1280.23.camel@rzhang1-toshiba> In-Reply-To: <1411001832.1280.23.camel@rzhang1-toshiba> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org thanks for the review Rui On Thursday 18 September 2014 06:27 AM, Zhang Rui wrote: > On Tue, 2014-09-16 at 16:27 +0530, Sanjay Singh Rawat wrote: >> With knowledge of supported thermal policies from this attribute, it helps in >> setting the policy without failure from the available ones. >> > Hmmm, I think it's better to reuse the "policy" attribute. > Say, > #cat policy > user_space [step_wise] fair_share > I'm not sure if this will break any userspace as it's an ABI change, but > we can give it a try, right? Looks good, but might break. So thought of simplified way of doing. > > thanks, > -rui >> Signed-off-by: Sanjay Singh Rawat >> --- >> drivers/thermal/thermal_core.c | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c >> index 71b0ec0..6caefcd 100644 >> --- a/drivers/thermal/thermal_core.c >> +++ b/drivers/thermal/thermal_core.c >> @@ -772,6 +772,25 @@ policy_show(struct device *dev, struct device_attribute *devattr, char *buf) >> return sprintf(buf, "%s\n", tz->governor->name); >> } >> >> +static ssize_t >> +available_policy_show(struct device *dev, struct device_attribute *devattr, >> + char *buf) >> +{ >> + ssize_t i = 0; >> + struct thermal_governor *temp; >> + struct thermal_zone_device *tz = to_thermal_zone(dev); >> + >> + mutex_lock(&tz->lock); >> + >> + list_for_each_entry(temp, &thermal_governor_list, governor_list) >> + i += sprintf(&buf[i], "%s ", temp->name); >> + >> + mutex_unlock(&tz->lock); >> + i += sprintf(&buf[i], "\n"); >> + >> + return i; >> +} >> + >> #ifdef CONFIG_THERMAL_EMULATION >> static ssize_t >> emul_temp_store(struct device *dev, struct device_attribute *attr, >> @@ -805,6 +824,7 @@ static DEVICE_ATTR(temp, 0444, temp_show, NULL); >> static DEVICE_ATTR(mode, 0644, mode_show, mode_store); >> static DEVICE_ATTR(passive, S_IRUGO | S_IWUSR, passive_show, passive_store); >> static DEVICE_ATTR(policy, S_IRUGO | S_IWUSR, policy_show, policy_store); >> +static DEVICE_ATTR(available_policy, S_IRUGO, available_policy_show, NULL); >> >> /* sys I/F for cooling device */ >> #define to_cooling_device(_dev) \ >> @@ -1538,6 +1558,10 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type, >> if (result) >> goto unregister; >> >> + result = device_create_file(&tz->device, &dev_attr_available_policy); >> + if (result) >> + goto unregister; >> + >> /* Update 'this' zone's governor information */ >> mutex_lock(&thermal_governor_lock); >> > -- sanjay