From: David Ahern <dsahern@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Alexander Yarygin <yarygin@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Mike Galbraith <efault@gmx.de>,
Namhyung Kim <namhyung.kim@lge.com>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 1/2] perf session: Add option to copy events when queueing
Date: Thu, 18 Sep 2014 14:29:28 -0600 [thread overview]
Message-ID: <541B40A8.8020406@gmail.com> (raw)
In-Reply-To: <541B3ECD.8000706@gmail.com>
On 9/18/14, 2:21 PM, David Ahern wrote:
> On 9/18/14, 12:53 PM, Arnaldo Carvalho de Melo wrote:
>> If nobody objects I'll merge this patch, as it fixes problems, but I
>> wonder if the best wouldn't be simply not calling
>> perf_evlist__mmap_consume() till the last event there is in fact
>> consumed... I.e. as we _really_ consume the events, we remove it from
>> there.
>>
>> Instead of consuming the event at perf_tool->sample() time, we would
>> do it at perf_tool->finished_round(), would that be feasible? Has anyone
>> tried this?
>
> Hmmm... haven't tried this. Conceptually it should work - at least
> nothing comes to mind at the moment.
Upon further review ...
Alex you might want to try this first. Malloc and copy of all events is
going to bring some serious overhead. Can avoid that if consuming the
event in finished_round works.
David
next prev parent reply other threads:[~2014-09-18 20:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 17:07 [PATCH 0/2] perf kvm stat live: Copy events Alexander Yarygin
2014-09-18 17:07 ` [PATCH 1/2] perf session: Add option to copy events when queueing Alexander Yarygin
2014-09-18 18:53 ` Arnaldo Carvalho de Melo
2014-09-18 20:21 ` David Ahern
2014-09-18 20:29 ` David Ahern [this message]
2014-09-19 8:48 ` Alexander Yarygin
2014-09-19 14:21 ` David Ahern
2014-09-19 16:25 ` Alexander Yarygin
2014-09-22 7:04 ` Jiri Olsa
2014-09-22 7:04 ` Jiri Olsa
2014-09-29 18:33 ` Arnaldo Carvalho de Melo
2014-09-18 17:07 ` [PATCH 2/2] perf kvm stat live: Enable events copying Alexander Yarygin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541B40A8.8020406@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=borntraeger@de.ibm.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=yarygin@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).