Re: [PATCH 2/4] drivers/bus: Freescale Management Complex (fsl-mc) bus driver

Joe Perches
2014-09-11T18:49:17Z

On Thu, 2014-09-11 at 12:34 -0500, J. German Rivera wrote:
> From: "J. German Rivera" <German.Rivera@freescale.com>
>
> Platform device driver that sets up the basic bus infrastructure
> for the fsl-mc bus type, including support for adding/removing
> fsl-mc devices, register/unregister of fsl-mc drivers, and bus
> match support to bind devices to drivers.

[]

> diff --git a/drivers/bus/fsl-mc/fsl_mc_bus.c b/drivers/bus/fsl-mc/fsl_mc_bus.c
[]
> +/**
> + * fsl_mc_bus_match - device to driver matching callback
> + * @dev: the MC object device structure to match against
> + * @drv: the device driver to search for matching MC object device id
> + * structures
> + *
> + * Returns 1 on success, 0 otherwise.
> + */
> +static int fsl_mc_bus_match(struct device *dev, struct device_driver *drv)
> +{
> + const struct fsl_mc_device_match_id *id;
> + struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
> + struct fsl_mc_driver *mc_drv = to_fsl_mc_driver(drv);
> + bool found = false;
[]
> +out:
> + pr_debug("%s: %s %s\n", __func__, dev_name(dev),
> + found ? "matched" : "not matched");

Thia should probably use dev_dbg

dev_dbg(dev, "%smatched\n", found ? "" : "not ");

and let the dynamic debug mechanism emit the
function name if desired.