Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs

Scott Wood
2014-09-18T23:53:43Z

On Thu, 2014-09-18 at 18:39 -0500, Yoder Stuart-B08248 wrote:
>
> > -----Original Message-----
> > From: Kim Phillips [mailto:kim.phillips@freescale.com]
> > Sent: Monday, September 15, 2014 6:45 PM
> > To: Rivera Jose-B46482
> > Cc: gregkh@linuxfoundation.org; arnd@arndb.de; linux-kernel@vger.kernel.org; Yoder Stuart-B08248; Phillips
> > Kim-R1AAHA; Wood Scott-B07421; agraf@suse.de; linuxppc-release@linux.freescale.net
> > Subject: Re: [PATCH 1/4] drivers/bus: Added Freescale Management Complex APIs
> >
> > On Thu, 11 Sep 2014 12:34:21 -0500
> > "J. German Rivera" <German.Rivera@freescale.com> wrote:
> >
> > > From: "J. German Rivera" <German.Rivera@freescale.com>
> > >
> > > APIs to access the Management Complex (MC) hardware
> > > module of Freescale LS2 SoCs. This patch includes
> > > APIs to check the MC firmware version and to manipulate
> > > DPRC objects in the MC.
> > >
> > > Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
> > > Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
> > > ---
> > > drivers/bus/fsl-mc/dpmng.c | 93 +++++
> > > drivers/bus/fsl-mc/dprc.c | 504 +++++++++++++++++++++++
> > > drivers/bus/fsl-mc/fsl_dpmng_cmd.h | 83 ++++
> > > drivers/bus/fsl-mc/fsl_dprc_cmd.h | 545 +++++++++++++++++++++++++
> > > drivers/bus/fsl-mc/fsl_mc_sys.c | 237 +++++++++++
> > > include/linux/fsl_dpmng.h | 120 ++++++
> > > include/linux/fsl_dprc.h | 790 ++++++++++++++++++++++++++++++++++++
> > > include/linux/fsl_mc_cmd.h | 182 +++++++++
> > > include/linux/fsl_mc_sys.h | 81 ++++
> > > 9 files changed, 2635 insertions(+)
> > > create mode 100644 drivers/bus/fsl-mc/dpmng.c
> > > create mode 100644 drivers/bus/fsl-mc/dprc.c
> > > create mode 100644 drivers/bus/fsl-mc/fsl_dpmng_cmd.h
> > > create mode 100644 drivers/bus/fsl-mc/fsl_dprc_cmd.h
> > > create mode 100644 drivers/bus/fsl-mc/fsl_mc_sys.c
> > > create mode 100644 include/linux/fsl_dpmng.h
> > > create mode 100644 include/linux/fsl_dprc.h
> > > create mode 100644 include/linux/fsl_mc_cmd.h
> > > create mode 100644 include/linux/fsl_mc_sys.h
> >
> > the fsl prefix in the filename fsl_dpmng_cmd.h is redundant with
> > its directory name fsl-mc/. Note that I find dashes ('-') in
> > filenames make them easier to type: is there a reason we're using
> > underscores here?
> >
> > Also, any reason why these and future include files aren't being put
> > in include/linux/fsl/, so as to not pollute the top level
> > include/linux/? That way, we can also remove the fsl- prefix from
> > those filenames, too..
>
> There is nothing in include/linux/fsl except 1 driver from 2 years ago.
> Why is that?
>
> I'd also prefer to see these headers is include/linux/fsl, but given that
> the directory is essentially unused it seemed that include/linux was more
> conventional.

I thought I saw some other patch dump some more things in there recently
-- maybe LS1 stuff?

-Scott