From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@canonical.com>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] blk-timeout: fix blk_add_timer
Date: Fri, 19 Sep 2014 08:12:11 -0600 [thread overview]
Message-ID: <541C39BB.8010804@kernel.dk> (raw)
In-Reply-To: <1411134826-6772-1-git-send-email-ming.lei@canonical.com>
On 09/19/2014 07:53 AM, Ming Lei wrote:
> Commit 8cb34819cdd5d(blk-mq: unshared timeout handler) introduces
> blk-mq's own timeout handler, and removes following line
>
> blk_queue_rq_timed_out(q, blk_mq_rq_timed_out);
>
> then cause blk_add_timer() to do nop in case of blk-mq.
>
> This patch fixes the problem by bypassing the check for blk-mq.
Good catch, this explains something I ran into yesterday on a missing
timer. I had a hard time understanding your description here, I'll
reword it a little bit and apply. Thanks!
--
Jens Axboe
prev parent reply other threads:[~2014-09-19 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 13:53 [PATCH] blk-timeout: fix blk_add_timer Ming Lei
2014-09-19 14:12 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541C39BB.8010804@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox