From: Dinh Nguyen <dinguyen@opensource.altera.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: <paulz@synopsys.com>, <gregkh@linuxfoundation.org>,
<balbi@ti.com>, <dinh.linux@gmail.com>, <swarren@wwwdotorg.org>,
<matthijs@stdin.nl>, <r.baldyga@samsung.com>,
<jg1.han@samsung.com>, <sachin.kamat@linaro.org>,
<ben-linux@fluff.org>, <dianders@chromium.org>,
<kever.yang@rock-chips.com>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv4 08/12] usb: dwc2: gadget: Do not fail probe if there isn't a clock node
Date: Fri, 19 Sep 2014 09:29:38 -0500 [thread overview]
Message-ID: <541C3DD2.9030501@opensource.altera.com> (raw)
In-Reply-To: <3825627.ZuOPzBNWiB@amdc1032>
On 9/12/14, 11:28 AM, Bartlomiej Zolnierkiewicz wrote:
>
> [ added linux-kernel ML to cc: ]
>
> Hi,
>
> On Tuesday, August 26, 2014 11:19:59 AM dinguyen@opensource.altera.com wrote:
>> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>>
>> Since the dwc2 hcd driver is currently not looking for a clock node during
>> init, we should not completely fail if there isn't a clock provided.
>> Add a check for a valid clock before calling clock functions.
>
> This doesn't look correct at least for the case when we are really missing
> the clock and USB_DWC2_PERIPHERAL=y (moreover it just looks wrong to access
> gadget functionalities when clock is disabled). It seems that it would be
> better to just disable gadget functionality on dwc2_gadget_init() failure
> in hcd and not call gadget functions later from hcd if gadget functionality
> is disabled.
>
Yes...this is correct. Will fix up in v5.
Thanks,
Dinh
next prev parent reply other threads:[~2014-09-19 14:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1409070003-21195-1-git-send-email-dinguyen@opensource.altera.com>
[not found] ` <1409070003-21195-2-git-send-email-dinguyen@opensource.altera.com>
2014-09-12 15:49 ` [PATCHv4 01/12] usb: dwc2: Update Kconfig to support dual-role Bartlomiej Zolnierkiewicz
2014-09-18 15:54 ` Dinh Nguyen
2014-09-18 19:59 ` Paul Zimmerman
2014-09-19 14:49 ` Bartlomiej Zolnierkiewicz
2014-09-19 19:02 ` Paul Zimmerman
2014-09-22 16:10 ` Bartlomiej Zolnierkiewicz
[not found] ` <1409070003-21195-3-git-send-email-dinguyen@opensource.altera.com>
2014-09-12 15:56 ` [PATCHv4 02/12] usb: dwc2: move "samsung,s3c6400-hsotg" into common platform Bartlomiej Zolnierkiewicz
[not found] ` <1409070003-21195-4-git-send-email-dinguyen@opensource.altera.com>
2014-09-12 16:08 ` [PATCHv4 03/12] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure Bartlomiej Zolnierkiewicz
[not found] ` <1409070003-21195-5-git-send-email-dinguyen@opensource.altera.com>
2014-09-12 16:18 ` [PATCHv4 04/12] usb: dwc2: Add the appropriate init calls in platform code Bartlomiej Zolnierkiewicz
2014-09-18 19:24 ` Dinh Nguyen
[not found] ` <1409070003-21195-9-git-send-email-dinguyen@opensource.altera.com>
2014-09-12 16:28 ` [PATCHv4 08/12] usb: dwc2: gadget: Do not fail probe if there isn't a clock node Bartlomiej Zolnierkiewicz
2014-09-19 14:29 ` Dinh Nguyen [this message]
[not found] ` <1409070003-21195-10-git-send-email-dinguyen@opensource.altera.com>
2014-09-12 16:34 ` [PATCHv4 09/12] usb: dwc2: initialize the spin_lock for both host and gadget Bartlomiej Zolnierkiewicz
[not found] ` <1409070003-21195-11-git-send-email-dinguyen@opensource.altera.com>
2014-09-12 16:36 ` [PATCHv4 10/12] usb: dwc2: Add suspend/resume for gadget Bartlomiej Zolnierkiewicz
[not found] ` <1409070003-21195-12-git-send-email-dinguyen@opensource.altera.com>
2014-09-12 16:38 ` [PATCHv4 11/12] usb: dwc2: check that the host work queue is valid Bartlomiej Zolnierkiewicz
2014-09-12 16:44 ` [PATCHv4 00/12] usb: dwc2: Add support for dual role Bartlomiej Zolnierkiewicz
2014-09-12 18:29 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541C3DD2.9030501@opensource.altera.com \
--to=dinguyen@opensource.altera.com \
--cc=b.zolnierkie@samsung.com \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=dianders@chromium.org \
--cc=dinh.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthijs@stdin.nl \
--cc=paulz@synopsys.com \
--cc=r.baldyga@samsung.com \
--cc=sachin.kamat@linaro.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox