From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757131AbaISO6V (ORCPT ); Fri, 19 Sep 2014 10:58:21 -0400 Received: from smtp73.ord1c.emailsrvr.com ([108.166.43.73]:34516 "EHLO smtp73.ord1c.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756696AbaISO6S (ORCPT ); Fri, 19 Sep 2014 10:58:18 -0400 X-Sender-Id: pramod.gurav@smartplayin.com Message-ID: <541C447F.7090608@smartplayin.com> Date: Fri, 19 Sep 2014 20:28:07 +0530 From: Pramod Gurav User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Guenter Roeck , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org CC: Josh Cartwright , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Stephen Boyd , linux-pm@vger.kernel.org Subject: Re: [PATCH] power: reset: use restart_notifier mechanism for msm poweroff References: <1411128415-20381-1-git-send-email-pramod.gurav@smartplayin.com> <541C3545.3090700@roeck-us.net> In-Reply-To: <541C3545.3090700@roeck-us.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter, Thanks for you. On 19-09-2014 07:23 PM, Guenter Roeck wrote: > On 09/19/2014 05:06 AM, Pramod Gurav wrote: >> This change uses replaces use of arm_pm_restart with recently introduced >> reset mechanism in Linux kernel called restart_notifier. >> >> Cc: Guenter Roeck >> Cc: Josh Cartwright >> Cc: Sebastian Reichel >> Cc: Dmitry Eremin-Solenikov >> Cc: David Woodhouse >> Cc: Stephen Boyd >> Cc: linux-pm@vger.kernel.org >> >> Signed-off-by: Pramod Gurav >> >> --- >> >> This patch is tested on DB8074 Target and are based on patchset [1] >> by Guenter Roeck. >> >> [1]: https://patchwork.kernel.org/patch/4746721/ >> >> drivers/power/reset/msm-poweroff.c | 18 +++++++++++++++--- >> 1 file changed, 15 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/power/reset/msm-poweroff.c b/drivers/power/reset/msm-poweroff.c >> index 774f9a3..59b368c 100644 >> --- a/drivers/power/reset/msm-poweroff.c >> +++ b/drivers/power/reset/msm-poweroff.c >> @@ -24,17 +24,21 @@ >> #include >> >> static void __iomem *msm_ps_hold; >> +static struct notifier_block restart_nb; >> >> -static void do_msm_restart(enum reboot_mode reboot_mode, const char *cmd) >> +static int do_msm_restart(struct notifier_block *nb, unsigned long action, >> + void *data) >> { >> writel(0, msm_ps_hold); >> mdelay(10000); >> + >> + return NOTIFY_DONE; >> } >> >> static void do_msm_poweroff(void) >> { >> /* TODO: Add poweroff capability */ >> - do_msm_restart(REBOOT_HARD, NULL); >> + do_msm_restart(&restart_nb, 0, NULL); >> } >> >> static int msm_restart_probe(struct platform_device *pdev) >> @@ -47,8 +51,16 @@ static int msm_restart_probe(struct platform_device *pdev) >> if (IS_ERR(msm_ps_hold)) >> return PTR_ERR(msm_ps_hold); >> >> + restart_nb.notifier_call = do_msm_restart; >> + restart_nb.priority = 128; > > Since the structure is static, you might as well initialize it there > and save a few bytes of code. > >> + if (register_restart_handler(&restart_nb)) { >> + dev_err(&pdev->dev, >> + "failed to setup restart handler.\n"); > > 'failed to register ...' might be a bit better wording. > >> + restart_nb.notifier_call = NULL; > > No need to set notifier_call to NULL. Will address the comments and send v2. > >> + } >> + >> pm_power_off = do_msm_poweroff; >> - arm_pm_restart = do_msm_restart; >> + >> return 0; >> } >> >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >