public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Liu Hua <sdu.liu@huawei.com>, shuah.khan@hp.com
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	peifeiyue@huawei.com, Jiri Kosina <trivial@kernel.org>
Subject: Re: [PATCH] Documentation: correct parameter error for dma_mapping_error
Date: Fri, 19 Sep 2014 10:01:28 -0700	[thread overview]
Message-ID: <541C6168.7030701@infradead.org> (raw)
In-Reply-To: <1411013728-56125-1-git-send-email-sdu.liu@huawei.com>

On 09/17/14 21:15, Liu Hua wrote:
> dma_mapping_error takes two parameters, but some of examples
> in Documentation/DMA-API-HOWTO.txt just takes one. So correct
> it.
> 
> Signed-off-by: Liu Hua <sdu.liu@huawei.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

Jiri, please apply this patch.  Thanks.

> ---
>  Documentation/DMA-API-HOWTO.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/DMA-API-HOWTO.txt b/Documentation/DMA-API-HOWTO.txt
> index dcbbe36..0f7afb2 100644
> --- a/Documentation/DMA-API-HOWTO.txt
> +++ b/Documentation/DMA-API-HOWTO.txt
> @@ -531,7 +531,7 @@ To map a single region, you do:
>  	size_t size = buffer->len;
>  
>  	dma_handle = dma_map_single(dev, addr, size, direction);
> -	if (dma_mapping_error(dma_handle)) {
> +	if (dma_mapping_error(dev, dma_handle)) {
>  		/*
>  		 * reduce current DMA mapping usage,
>  		 * delay and try again later or
> @@ -588,7 +588,7 @@ Specifically:
>  	size_t size = buffer->len;
>  
>  	dma_handle = dma_map_page(dev, page, offset, size, direction);
> -	if (dma_mapping_error(dma_handle)) {
> +	if (dma_mapping_error(dev, dma_handle)) {
>  		/*
>  		 * reduce current DMA mapping usage,
>  		 * delay and try again later or
> @@ -689,7 +689,7 @@ to use the dma_sync_*() interfaces.
>  		dma_addr_t mapping;
>  
>  		mapping = dma_map_single(cp->dev, buffer, len, DMA_FROM_DEVICE);
> -		if (dma_mapping_error(dma_handle)) {
> +		if (dma_mapping_error(cp->dev, dma_handle)) {
>  			/*
>  			 * reduce current DMA mapping usage,
>  			 * delay and try again later or
> 


-- 
~Randy

      reply	other threads:[~2014-09-19 17:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18  4:15 [PATCH] Documentation: correct parameter error for dma_mapping_error Liu Hua
2014-09-19 17:01 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541C6168.7030701@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peifeiyue@huawei.com \
    --cc=sdu.liu@huawei.com \
    --cc=shuah.khan@hp.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox