* [PATCH] Documentation: correct parameter error for dma_mapping_error
@ 2014-09-18 4:15 Liu Hua
2014-09-19 17:01 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Liu Hua @ 2014-09-18 4:15 UTC (permalink / raw)
To: rdunlap, shuah.khan; +Cc: linux-doc, linux-kernel, peifeiyue
dma_mapping_error takes two parameters, but some of examples
in Documentation/DMA-API-HOWTO.txt just takes one. So correct
it.
Signed-off-by: Liu Hua <sdu.liu@huawei.com>
---
Documentation/DMA-API-HOWTO.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/DMA-API-HOWTO.txt b/Documentation/DMA-API-HOWTO.txt
index dcbbe36..0f7afb2 100644
--- a/Documentation/DMA-API-HOWTO.txt
+++ b/Documentation/DMA-API-HOWTO.txt
@@ -531,7 +531,7 @@ To map a single region, you do:
size_t size = buffer->len;
dma_handle = dma_map_single(dev, addr, size, direction);
- if (dma_mapping_error(dma_handle)) {
+ if (dma_mapping_error(dev, dma_handle)) {
/*
* reduce current DMA mapping usage,
* delay and try again later or
@@ -588,7 +588,7 @@ Specifically:
size_t size = buffer->len;
dma_handle = dma_map_page(dev, page, offset, size, direction);
- if (dma_mapping_error(dma_handle)) {
+ if (dma_mapping_error(dev, dma_handle)) {
/*
* reduce current DMA mapping usage,
* delay and try again later or
@@ -689,7 +689,7 @@ to use the dma_sync_*() interfaces.
dma_addr_t mapping;
mapping = dma_map_single(cp->dev, buffer, len, DMA_FROM_DEVICE);
- if (dma_mapping_error(dma_handle)) {
+ if (dma_mapping_error(cp->dev, dma_handle)) {
/*
* reduce current DMA mapping usage,
* delay and try again later or
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Documentation: correct parameter error for dma_mapping_error
2014-09-18 4:15 [PATCH] Documentation: correct parameter error for dma_mapping_error Liu Hua
@ 2014-09-19 17:01 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2014-09-19 17:01 UTC (permalink / raw)
To: Liu Hua, shuah.khan; +Cc: linux-doc, linux-kernel, peifeiyue, Jiri Kosina
On 09/17/14 21:15, Liu Hua wrote:
> dma_mapping_error takes two parameters, but some of examples
> in Documentation/DMA-API-HOWTO.txt just takes one. So correct
> it.
>
> Signed-off-by: Liu Hua <sdu.liu@huawei.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
Jiri, please apply this patch. Thanks.
> ---
> Documentation/DMA-API-HOWTO.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/DMA-API-HOWTO.txt b/Documentation/DMA-API-HOWTO.txt
> index dcbbe36..0f7afb2 100644
> --- a/Documentation/DMA-API-HOWTO.txt
> +++ b/Documentation/DMA-API-HOWTO.txt
> @@ -531,7 +531,7 @@ To map a single region, you do:
> size_t size = buffer->len;
>
> dma_handle = dma_map_single(dev, addr, size, direction);
> - if (dma_mapping_error(dma_handle)) {
> + if (dma_mapping_error(dev, dma_handle)) {
> /*
> * reduce current DMA mapping usage,
> * delay and try again later or
> @@ -588,7 +588,7 @@ Specifically:
> size_t size = buffer->len;
>
> dma_handle = dma_map_page(dev, page, offset, size, direction);
> - if (dma_mapping_error(dma_handle)) {
> + if (dma_mapping_error(dev, dma_handle)) {
> /*
> * reduce current DMA mapping usage,
> * delay and try again later or
> @@ -689,7 +689,7 @@ to use the dma_sync_*() interfaces.
> dma_addr_t mapping;
>
> mapping = dma_map_single(cp->dev, buffer, len, DMA_FROM_DEVICE);
> - if (dma_mapping_error(dma_handle)) {
> + if (dma_mapping_error(cp->dev, dma_handle)) {
> /*
> * reduce current DMA mapping usage,
> * delay and try again later or
>
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-19 17:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-18 4:15 [PATCH] Documentation: correct parameter error for dma_mapping_error Liu Hua
2014-09-19 17:01 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox