[PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

[PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

[Chen Gang]

Need include it for irq_of_parse_and_map(), the related error with
allmodconfig under microblaze:

  drivers/usb/host/ehci-xilinx-of.c: In function ‘ehci_hcd_xilinx_of_probe’:
  drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ‘irq_of_parse_and_map’ [-Werror=implicit-function-declaration]
    irq = irq_of_parse_and_map(dn, 0);
    ^

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 drivers/usb/host/ehci-xilinx-of.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
index fe57710..a232836 100644
--- a/drivers/usb/host/ehci-xilinx-of.c
+++ b/drivers/usb/host/ehci-xilinx-of.c
@@ -31,6 +31,7 @@
 #include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/of_address.h>
+#include <linux/of_irq.h>
 
 /**
  * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
-- 
1.9.3

Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

[Michal Simek]

[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]

On 09/03/2014 05:50 PM, Chen Gang wrote:
> Need include it for irq_of_parse_and_map(), the related error with
> allmodconfig under microblaze:
> 
>   drivers/usb/host/ehci-xilinx-of.c: In function ‘ehci_hcd_xilinx_of_probe’:
>   drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ‘irq_of_parse_and_map’ [-Werror=implicit-function-declaration]
>     irq = irq_of_parse_and_map(dn, 0);
>     ^
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  drivers/usb/host/ehci-xilinx-of.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
> index fe57710..a232836 100644
> --- a/drivers/usb/host/ehci-xilinx-of.c
> +++ b/drivers/usb/host/ehci-xilinx-of.c
> @@ -31,6 +31,7 @@
>  #include <linux/of.h>
>  #include <linux/of_platform.h>
>  #include <linux/of_address.h>
> +#include <linux/of_irq.h>
>  
>  /**
>   * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
> 

Acked-by: Michal Simek <monstr@monstr.eu>

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

[Chen Gang]

Hello Maintainers:

Please help check this patch, when you have time.

Thanks.

On 09/08/2014 01:20 PM, Michal Simek wrote:
> On 09/03/2014 05:50 PM, Chen Gang wrote:
>> Need include it for irq_of_parse_and_map(), the related error with
>> allmodconfig under microblaze:
>>
>>   drivers/usb/host/ehci-xilinx-of.c: In function ‘ehci_hcd_xilinx_of_probe’:
>>   drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ‘irq_of_parse_and_map’ [-Werror=implicit-function-declaration]
>>     irq = irq_of_parse_and_map(dn, 0);
>>     ^
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>>  drivers/usb/host/ehci-xilinx-of.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
>> index fe57710..a232836 100644
>> --- a/drivers/usb/host/ehci-xilinx-of.c
>> +++ b/drivers/usb/host/ehci-xilinx-of.c
>> @@ -31,6 +31,7 @@
>>  #include <linux/of.h>
>>  #include <linux/of_platform.h>
>>  #include <linux/of_address.h>
>> +#include <linux/of_irq.h>
>>  
>>  /**
>>   * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
>>
> 
> Acked-by: Michal Simek <monstr@monstr.eu>
> 
> Thanks,
> Michal
> 

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

[Michal Simek]

Hi Alan and Greg,

On 09/20/2014 06:19 AM, Chen Gang wrote:
> Hello Maintainers:
> 
> Please help check this patch, when you have time.
> 
> Thanks.
> 
> On 09/08/2014 01:20 PM, Michal Simek wrote:
>> On 09/03/2014 05:50 PM, Chen Gang wrote:
>>> Need include it for irq_of_parse_and_map(), the related error with
>>> allmodconfig under microblaze:
>>>
>>>   drivers/usb/host/ehci-xilinx-of.c: In function ‘ehci_hcd_xilinx_of_probe’:
>>>   drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ‘irq_of_parse_and_map’ [-Werror=implicit-function-declaration]
>>>     irq = irq_of_parse_and_map(dn, 0);
>>>     ^
>>>
>>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>>> ---
>>>  drivers/usb/host/ehci-xilinx-of.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
>>> index fe57710..a232836 100644
>>> --- a/drivers/usb/host/ehci-xilinx-of.c
>>> +++ b/drivers/usb/host/ehci-xilinx-of.c
>>> @@ -31,6 +31,7 @@
>>>  #include <linux/of.h>
>>>  #include <linux/of_platform.h>
>>>  #include <linux/of_address.h>
>>> +#include <linux/of_irq.h>
>>>  
>>>  /**
>>>   * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
>>>
>>
>> Acked-by: Michal Simek <monstr@monstr.eu>

Alan: Can you please add this patch to your queue?
Greg: If Alan is not maintaining this part of kernel, is this patch in your queue?

I have also not a problem to add this patch through my microblaze tree
but I think it will be much better to use any USB tree.

Thanks,
Michal

Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

[Alan Stern]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: TEXT/PLAIN; charset=UTF-8, Size: 1775 bytes --]

On Mon, 22 Sep 2014, Michal Simek wrote:

> Hi Alan and Greg,
> 
> On 09/20/2014 06:19 AM, Chen Gang wrote:
> > Hello Maintainers:
> > 
> > Please help check this patch, when you have time.
> > 
> > Thanks.
> > 
> > On 09/08/2014 01:20 PM, Michal Simek wrote:
> >> On 09/03/2014 05:50 PM, Chen Gang wrote:
> >>> Need include it for irq_of_parse_and_map(), the related error with
> >>> allmodconfig under microblaze:
> >>>
> >>>   drivers/usb/host/ehci-xilinx-of.c: In function ‘ehci_hcd_xilinx_of_probe’:
> >>>   drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ‘irq_of_parse_and_map’ [-Werror=implicit-function-declaration]
> >>>     irq = irq_of_parse_and_map(dn, 0);
> >>>     ^
> >>>
> >>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> >>> ---
> >>>  drivers/usb/host/ehci-xilinx-of.c | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
> >>> index fe57710..a232836 100644
> >>> --- a/drivers/usb/host/ehci-xilinx-of.c
> >>> +++ b/drivers/usb/host/ehci-xilinx-of.c
> >>> @@ -31,6 +31,7 @@
> >>>  #include <linux/of.h>
> >>>  #include <linux/of_platform.h>
> >>>  #include <linux/of_address.h>
> >>> +#include <linux/of_irq.h>
> >>>  
> >>>  /**
> >>>   * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
> >>>
> >>
> >> Acked-by: Michal Simek <monstr@monstr.eu>
> 
> Alan: Can you please add this patch to your queue?
> Greg: If Alan is not maintaining this part of kernel, is this patch in your queue?
> 
> I have also not a problem to add this patch through my microblaze tree
> but I think it will be much better to use any USB tree.

Greg should be able to accept a trivial patch like this one directly.

Alan Stern

Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

[Greg Kroah-Hartman]

On Wed, Sep 24, 2014 at 11:41:55AM -0400, Alan Stern wrote:
> On Mon, 22 Sep 2014, Michal Simek wrote:
> 
> > Hi Alan and Greg,
> > 
> > On 09/20/2014 06:19 AM, Chen Gang wrote:
> > > Hello Maintainers:
> > > 
> > > Please help check this patch, when you have time.
> > > 
> > > Thanks.
> > > 
> > > On 09/08/2014 01:20 PM, Michal Simek wrote:
> > >> On 09/03/2014 05:50 PM, Chen Gang wrote:
> > >>> Need include it for irq_of_parse_and_map(), the related error with
> > >>> allmodconfig under microblaze:
> > >>>
> > >>>   drivers/usb/host/ehci-xilinx-of.c: In function ?ehci_hcd_xilinx_of_probe?:
> > >>>   drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ?irq_of_parse_and_map? [-Werror=implicit-function-declaration]
> > >>>     irq = irq_of_parse_and_map(dn, 0);
> > >>>     ^
> > >>>
> > >>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> > >>> ---
> > >>>  drivers/usb/host/ehci-xilinx-of.c | 1 +
> > >>>  1 file changed, 1 insertion(+)
> > >>>
> > >>> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
> > >>> index fe57710..a232836 100644
> > >>> --- a/drivers/usb/host/ehci-xilinx-of.c
> > >>> +++ b/drivers/usb/host/ehci-xilinx-of.c
> > >>> @@ -31,6 +31,7 @@
> > >>>  #include <linux/of.h>
> > >>>  #include <linux/of_platform.h>
> > >>>  #include <linux/of_address.h>
> > >>> +#include <linux/of_irq.h>
> > >>>  
> > >>>  /**
> > >>>   * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
> > >>>
> > >>
> > >> Acked-by: Michal Simek <monstr@monstr.eu>
> > 
> > Alan: Can you please add this patch to your queue?
> > Greg: If Alan is not maintaining this part of kernel, is this patch in your queue?
> > 
> > I have also not a problem to add this patch through my microblaze tree
> > but I think it will be much better to use any USB tree.
> 
> Greg should be able to accept a trivial patch like this one directly.

I can, if someone will resend it so I can apply it :)

thanks,

greg k-h

Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

[Chen Gang]

On 9/29/14 9:52, Greg Kroah-Hartman wrote:
> On Wed, Sep 24, 2014 at 11:41:55AM -0400, Alan Stern wrote:
>> On Mon, 22 Sep 2014, Michal Simek wrote:
>>
>>> Alan: Can you please add this patch to your queue?
>>> Greg: If Alan is not maintaining this part of kernel, is this patch in your queue?
>>>
>>> I have also not a problem to add this patch through my microblaze tree
>>> but I think it will be much better to use any USB tree.
>>
>> Greg should be able to accept a trivial patch like this one directly.
> 
> I can, if someone will resend it so I can apply it :)
> 

This patch you have already applied (applied this patch in 2014-09-24),
so I need not resend it.

Thank all of you for your work.

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed