linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Jiri Olsa <jolsa@redhat.com>, Milian Wolff <mail@milianw.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHSET 0/5] perf tools: Add call-graph config options
Date: Sun, 21 Sep 2014 12:25:06 -0600	[thread overview]
Message-ID: <541F1802.6000806@gmail.com> (raw)
In-Reply-To: <1411229886-24390-1-git-send-email-namhyung@kernel.org>

On 9/20/14, 10:18 AM, Namhyung Kim wrote:
> Hello,
>
> This is patchset to add new callchain related config options so that
> users don't need to pass their preference to the cmdline everytime.
>
> Following config options will be added, and users can set appropriate
> values to ~/.perfconfig file.  Note that the dump-size option is
> meaningful only if record-mode = dwarf.
>
>    $ cat ~/.perfconfig
>    [call-graph]
>      record-mode = dwarf
>      dump-size = 4096
>      print-type = graph
>      order = callee
>      threshold = 0.5
>      print-limit = 128
>      sort-key = function
>
>    $ perf record -vg sleep 1
>    callchain: type DWARF
>    callchain: stack dump size 4096
>    mmap size 528384B
>    [ perf record: Woken up 1 times to write data ]
>    [ perf record: Captured and wrote 0.054 MB perf.data (~2378 samples) ]
>    Looking at the vmlinux_path (7 entries long)
>    Using /lib/modules/3.16.3-1-ARCH/build/vmlinux for symbols
>
>
> You can also get this from 'perf/callchain-config-v1' branch on my tree
>
>    git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
>

Looks ok to me. Reviewed-by: David Ahern <dsahern@gmail.com>


  parent reply	other threads:[~2014-09-21 18:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-20 16:18 [PATCHSET 0/5] perf tools: Add call-graph config options Namhyung Kim
2014-09-20 16:18 ` [PATCH 1/5] perf hists browser: Fix callchain print bug on TUI Namhyung Kim
2014-09-20 16:18 ` [PATCH 2/5] perf tools: Move callchain config from record_opts to callchain_param Namhyung Kim
2014-09-20 16:18 ` [PATCH 3/5] perf tools: Move some callchain parser functions to callchain.c Namhyung Kim
2014-09-20 16:18 ` [PATCH 4/5] perf tools: Introduce perf_callchain_config() Namhyung Kim
2014-09-22 14:24   ` Jiri Olsa
2014-09-22 15:19     ` Namhyung Kim
2014-09-22 14:25   ` Jiri Olsa
2014-09-22 14:51     ` Arnaldo Carvalho de Melo
2014-09-22 15:12       ` Namhyung Kim
2014-09-20 16:18 ` [PATCH 5/5] perf tools: Convert {record,top}.call-graph option to call-graph.record-mode Namhyung Kim
2014-09-21 18:25 ` David Ahern [this message]
2014-09-22 14:27 ` [PATCHSET 0/5] perf tools: Add call-graph config options Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541F1802.6000806@gmail.com \
    --to=dsahern@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@milianw.de \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).