From: Arjan van de Ven <arjan@linux.intel.com>
To: Mathias Krause <minipli@googlemail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCHv2 2/3] x86, ptdump: Simplify page flag evaluation code
Date: Sun, 21 Sep 2014 12:49:33 -0700 [thread overview]
Message-ID: <541F2BCD.2040007@linux.intel.com> (raw)
In-Reply-To: <1411313216-2641-3-git-send-email-minipli@googlemail.com>
On 9/21/2014 8:26 AM, Mathias Krause wrote:
> - if (pr & _PAGE_PCD)
> - pt_dump_cont_printf(m, dmsg, "PCD ");
> - else
> - pt_dump_cont_printf(m, dmsg, " ");
> + pt_dump_cont(m, dmsg, "%-4s", pr & _PAGE_USER ? "USR" : "");
while you have some nice cleanups in your patch, I can't say I consider this an improvement.
Yes the C standard allows ? to be used like this
but no, I don't think it improves readability in general.
(I think for me the main exception is NULL pointer cases, but this is not one of these)
next prev parent reply other threads:[~2014-09-21 19:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 15:26 [PATCHv2 0/3] x86, ptdump: a EFI related fix + enhancements Mathias Krause
2014-09-21 15:26 ` [PATCHv2 1/3] x86, ptdump: Add section for EFI runtime services Mathias Krause
2014-10-03 13:47 ` Matt Fleming
2014-10-07 15:01 ` Borislav Petkov
2014-10-07 17:07 ` Mathias Krause
2014-10-08 15:17 ` Borislav Petkov
2014-10-08 21:58 ` Mathias Krause
2014-10-08 22:26 ` Borislav Petkov
2014-10-12 12:55 ` Mathias Krause
2014-10-28 18:57 ` Borislav Petkov
2014-10-28 19:48 ` Mathias Krause
2014-10-28 20:13 ` Borislav Petkov
2014-10-28 21:14 ` Mathias Krause
2014-10-28 21:26 ` Borislav Petkov
2014-10-28 21:49 ` Mathias Krause
2014-10-28 22:07 ` Borislav Petkov
2014-10-29 8:06 ` Mathias Krause
2014-10-29 14:20 ` Matt Fleming
2014-10-29 15:19 ` Mathias Krause
2014-10-29 14:22 ` Matt Fleming
2014-10-29 15:22 ` Mathias Krause
2014-11-11 21:59 ` Mathias Krause
2014-11-11 22:32 ` Matt Fleming
2014-09-21 15:26 ` [PATCHv2 2/3] x86, ptdump: Simplify page flag evaluation code Mathias Krause
2014-09-21 19:49 ` Arjan van de Ven [this message]
2014-09-21 20:33 ` Mathias Krause
2014-09-24 7:45 ` Ingo Molnar
2014-09-25 19:27 ` Mathias Krause
2014-09-26 9:25 ` Ingo Molnar
2014-09-26 10:11 ` Borislav Petkov
2014-09-26 11:15 ` Ingo Molnar
2014-09-26 12:35 ` Mathias Krause
2014-09-21 15:26 ` [PATCHv2 3/3] x86, ptdump: Take parent page flags into account Mathias Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541F2BCD.2040007@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=minipli@googlemail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).